Network Topology graph "twitches"

[Marek Lyčka]

The Network Topology graph goes through periodic updates to synchronize server data. On each update, the graph is redrawn which causes visual glitching. Depending on the graph complexity, this may manifest anywhere from a slight 'twitch' to a full blown node reorganization which may completely change the way the graph looks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/503539

[Ameed Ashour (ameeda)]

@Marek Lyčka: are you still working on this bug ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/543231

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/543231
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e5dae9b35349c53fa6184e415e254094893cab1f
Submitter: Zuul
Branch: master

commit e5dae9b35349c53fa6184e415e254094893cab1f
Author: Ameed Ashour <email address hidden>
Date: Sun Feb 11 09:52:52 2018 -0500

    Network Topology graph "twitches"

    the graph is redrawn which causes visual glitching.
    Depending on the graph complexity.

    my patch resolved this issue so I compare between previous
    data and received data, if that changed it will redrawn,
    otherwise it keeps running.

    Change-Id: I813dfb329f46cda9afacce89c9a8b84eb2827115
    Closes-Bug: #1716834

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/575073

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/575073
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1ca8555011ad345e6343eded2fcca4516aa70944
Submitter: Zuul
Branch: master

commit 1ca8555011ad345e6343eded2fcca4516aa70944
Author: Akihiro Motoki <email address hidden>
Date: Wed Jun 13 19:37:40 2018 +0900

    Fix styling issues in networktopologycommon.js

    Follow-up patch for https://review.openstack.org/#/c/543231/
    No indent, 2-char indent and 4-char indent are used mixedly.

    TrivialFix

    Change-Id: I6e190d49c0ba908ab87b4d810ebbec70ee184b15
    Related-Bug: #1716834

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 14.0.0.0b3 development milestone.

[Akihiro Motoki (amotoki)]

After merging https://review.openstack.org/543231, bug 1786628 happens.

Considering the situation that Rocky release is approaching, we would like to revert the patch in Rocky release.
The change itself is a nice improvement, so if anyone has time in Stein release we can revisit the change.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/591161

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/593629

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: stable/rocky
Review: https://review.openstack.org/593629

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/591161
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9fbdc81038d13864c9280102c6a357e29f259ac5
Submitter: Zuul
Branch: master

commit 9fbdc81038d13864c9280102c6a357e29f259ac5
Author: Akihiro Motoki <email address hidden>
Date: Sat Aug 11 16:31:51 2018 +0000

    Revert "Network Topology graph "twitches""

    This reverts commit e5dae9b35349c53fa6184e415e254094893cab1f
    (and commit 1ca8555011ad345e6343eded2fcca4516aa70944 which is
    a follow-up styling fix).

    The reverted commit itself is a nice improvement,
    but considering the situation that Rocky release is approaching
    at the end of August we revert this to recover the original
    user-visible behavior. It would be nice if someone can revisit
    the improvement in the next Stein release.

    Change-Id: If324bd47a1b8c1b9579c1f38adeae31fdf583780
    Closes-Bug: #1786628
    Related-Bug: #1716834

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/593629
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=364b8155000be4a5d00e5fd483185908d1090f8f
Submitter: Zuul
Branch: stable/rocky

commit 364b8155000be4a5d00e5fd483185908d1090f8f
Author: Akihiro Motoki <email address hidden>
Date: Sat Aug 11 16:31:51 2018 +0000

    Revert "Network Topology graph "twitches""

    This reverts commit e5dae9b35349c53fa6184e415e254094893cab1f
    (and commit 1ca8555011ad345e6343eded2fcca4516aa70944 which is
    a follow-up styling fix).

    The reverted commit itself is a nice improvement,
    but considering the situation that Rocky release is approaching
    at the end of August we revert this to recover the original
    user-visible behavior. It would be nice if someone can revisit
    the improvement in the next Stein release.

    Change-Id: If324bd47a1b8c1b9579c1f38adeae31fdf583780
    Closes-Bug: #1786628
    Related-Bug: #1716834
    (cherry picked from commit 9fbdc81038d13864c9280102c6a357e29f259ac5)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/503539
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.