OpenStack Dashboard (Horizon)

ICMP type/code should be optional in Security Group creation form

Bug #1712025 reported by Akihiro Motoki on 2017-08-21

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Low	Akihiro Motoki	OpenStack Dashboard (Horizon) queens-1

Bug Description

In the "Add Rule" (security group) form, when "Custom ICMP rule" is selected, "Type" and "Code" are both marked as required. In Neutron API, ICMP rule can be created without specifying both ICMP type and code.

You can create
- an ICMP rule without ICMP type and ICMP code
- and ICMP rule only with ICMP type

Tags:

OpenStack Infra (hudson-openstack) on 2017-08-21

Changed in horizon:
status:	New → In Progress

Revision history for this message

Akihiro Motoki (amotoki) wrote on 2017-08-21:

https://review.openstack.org/494445

Changed in horizon:
importance:	Medium → Low

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-21: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/494445
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c6c24eda59f8203f112125a4d1c073158576dd6b
Submitter: Jenkins
Branch: master

commit c6c24eda59f8203f112125a4d1c073158576dd6b
Author: Akihiro Motoki <email address hidden>
Date: Thu Aug 17 08:43:44 2017 +0000

Make icmp_type/code optional

In Neutron API icmp_type/code are not required fields,
so they should be optional.

    Previously we support Nova API which requires icmp_type
    and icmp_code but we dropped Nova security group API support in Pike
    and we no longer need to care it.

Change-Id: Ie460e763928b4f50f84c38d88556df632078ba42
Closes-Bug: #1712025

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-27: Fix included in openstack/horizon 13.0.0.0b1

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-01-16: Fix proposed to horizon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/534357

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-05: Fix merged to horizon (stable/pike)

Reviewed: https://review.openstack.org/534357
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=60a2d59c597a633daca38aaab0a357f0151d3014
Submitter: Zuul
Branch: stable/pike

commit 60a2d59c597a633daca38aaab0a357f0151d3014
Author: Akihiro Motoki <email address hidden>
Date: Thu Aug 17 08:43:44 2017 +0000

Make icmp_type/code optional

In Neutron API icmp_type/code are not required fields,
so they should be optional.

    Previously we support Nova API which requires icmp_type
    and icmp_code but we dropped Nova security group API support in Pike
    and we no longer need to care it.

    Change-Id: Ie460e763928b4f50f84c38d88556df632078ba42
    Closes-Bug: #1712025
    (cherry picked from commit c6c24eda59f8203f112125a4d1c073158576dd6b)