Unable to add security rule to security group - horizon

[cooldharma06]

i installed devstack and running openstack. i am trying to add security rules to new security group and its not adding. The Add rule(Input) message box doesnt disappears from the dashboard.

In browser console i am getting the error as :

An invalid form control with name='icmp_type' is not focusable.
(index):1 An invalid form control with name='icmp_code' is not focusable.

[Akihiro Motoki (amotoki)]

Only "Custom ICMP rule" can be created..

[Akihiro Motoki (amotoki)]

required=True (default value) is used for icmp_type and icmp_code and it seems this prevents from creating a rule. Perhaps the form tries to show some error message to icmp_type and icmp_code, but they are not visible and it causes a console message "An invalid form control with name='icmp_type' is not focusable.".

I don't know what is the right solution on this, but in this case we are lucky as icmp_code and icmp_type are not required fields in neutron security group API. They are required in nova security group API but we dropped the support for nova-network security group support in Pike. We can avoid the bug by specifying required=False to icmp_type/code.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/494445

[Akihiro Motoki (amotoki)]

This is caused by the same reason for bug 1708601. bug 1708601 will solve the root cause.

https://review.openstack.org/494445 is also a valid fix as ICMP type/code are not required fields.