Wrong nova.server_list handling for several tabs

[Oleksii]

Tabs /projects/volumes, /project/floating_ips/ and some other have wrong handling for api.nova.server_list, e.g.
/usr/share/openstack-dashboard/openstack_dashboard/dashboards/project/volumes/tabs.py: instances, has_more = api.nova.server_list(self.request,search_opts=search_opts,detailed=False)
meanwhile it returns 3 values:
ValueError: 'too many values to unpack'
(Pdb) api.nova.server_list(self.request,search_opts=search_opts,detailed=False)
([<Server: {'id': u'26c2173c-322d-4944-a286-5cb7078cd411', 'links': [{u'href': u'http://10.101.0.46:8774/v2.1/09ded4150fb84f96a44cbf91e203d4e1/servers/26c2173c-322d-4944-a286-5cb7078cd411', u'rel': u'self'}, {u'href': u'http://10.101.0.46:8774/09ded4150fb84f96a44cbf91e203d4e1/servers/26c2173c-322d-4944-a286-5cb7078cd411', u'rel': u'bookmark'}], 'name': u'test2'}>, <Server: {'id': u'99d5e094-e1a8-4657-9c63-b689347b7366', 'links': [{u'href': u'http://10.101.0.46:8774/v2.1/09ded4150fb84f96a44cbf91e203d4e1/servers/99d5e094-e1a8-4657-9c63-b689347b7366', u'rel': u'self'}, {u'href': u'http://10.101.0.46:8774/09ded4150fb84f96a44cbf91e203d4e1/servers/99d5e094-e1a8-4657-9c63-b689347b7366', u'rel': u'bookmark'}], 'name': u'test'}>], False, False)

Error in horizon for /projects/volumes doesn't give any idea about the problem ("Error: Unable to retrieve volume/instance attachment information").

Please note, that other tabs has correct handling:
/usr/share/openstack-dashboard/openstack_dashboard/dashboards/project/network_topology/views.py: servers, more, __ = api.nova.server_list(request)

[Oleksii (ozhurba)]

Issue exists in stable Ocata release

[Akihiro Motoki (amotoki)]

stable/ocata openstack_dashboard.api.nova.server_list returns (servers, has_more_data) [1], so the data you observed ([...], False, False) looks odd. Where did you get the horizon code from?

[1] https://github.com/openstack/horizon/blob/stable/ocata/openstack_dashboard/api/nova.py#L726

[Oleksii (ozhurba)]

You are right, sorry. Not an upstream bug.