Npm tests are hardcoded against python2.7

Bug #1706980 reported by Pascal Boutin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Pascal Boutin

Bug Description

When I run the tests on my machine, it fails saying that angular is not defined. I saw that I had all the xtstatic files under python3.4/ while the tests tries to resolve them from python2.7/.

This comes from the 2 karma.conf files since the python2.7 path is hardcoded there.

It should be more flexible.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/487862

Changed in horizon:
assignee: nobody → Pascal Boutin (pboutin)
status: New → In Progress
Changed in horizon:
milestone: none → pike-rc1
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/487862
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0dc5a8230e86495df7fb153913929425be500f38
Submitter: Jenkins
Branch: master

commit 0dc5a8230e86495df7fb153913929425be500f38
Author: Pascal Boutin <email address hidden>
Date: Thu Jul 27 10:01:33 2017 -0400

    Makes the xstatic files lookup dynamic in the tests

    This change makes it so the tests will look for the actual
    python folder where the xstatic files are located instead
    of looking only for a python2.7/ folder.

    Change-Id: Ib2a56475b79b002085922ab752038239635fb9a5
    Closes-bug: #1706980

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0rc1

This issue was fixed in the openstack/horizon 12.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.