Launching instance from image causes image to be deallocated

[Chiew Yee Xin]

Steps to reproduce:

1. Go to Project > Compute > Images
2. Click "Launch" on one of the images to launch an instance.
3. Go to "Source" tab. The image selected is not allocated and does not appear in the available list.

I realize that the image was initially allocated but was then de-allocated when changeBootSource(selectedSource) was called repeatedly: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js#L440

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/484619

[Gary W. Smith (gary-w-smith)]

This is working correctly. This image that is selected appears in the "Allocated" table rather than the "Available" table on the Source tab.

The description hints that by selecting another item in the boot source box (e.g. Volume) and then re-selecting "Image" that the originally selected image appears under Available instead of Allocated, but that is also reasonable behavior.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/484619
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.