Add "default" rule when generate policy.yaml.sample

[Damon Li]

When we use tox to generate "policy.yaml.sample", the "default" policy is not included in the file. The default rule is enforced when a requested rule is not found. I think it's necessary for our project.

By the way, I tried to use "policy.yaml" generated by nova in horizon. And horizon can't show the "Admin->Instances" panel. I found this panel need a rule called "compute:get_all". I found the default policy file in horizon called "nova_policy.json" has "default" rule. So it can work well.

So I think we should add this "default" rule when we generate "policy.yaml.sample" in nova.

[Damon Li (damonl1)]

Please review: https://review.openstack.org/#/c/481443/

[Matt Riedemann (mriedem)]

compute:get_all doesn't exist in nova policy anymore:

https://docs.openstack.org/nova/latest/sample_policy.html

So this actually sounds like a Horizon bug.

[Matt Riedemann (mriedem)]

There is no compute:get_all in horizon's default nova_policy.json either:

https://github.com/openstack/horizon/blob/master/openstack_dashboard/conf/nova_policy.json

Which version of Horizon are you using?

[Matt Riedemann (mriedem)]

Horizon is hard-coded the old rule:

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/instances/panel.py#L29

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483501

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/483501
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=69c81b16e07b67ba0a0bc8e1f55049e7987c5b8c
Submitter: Jenkins
Branch: master

commit 69c81b16e07b67ba0a0bc8e1f55049e7987c5b8c
Author: Rob Cresswell <email address hidden>
Date: Thu Jul 13 19:27:22 2017 +0100

    Fix an incorrect policy rule in Admin > Instances

    Change-Id: I765ae0c36d19c88138fbea9545a2ca4791377ffb
    Closes-Bug: #1703066

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/483531

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/483531
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9aa0915eb85c6b12676b789741a6964d43a60e28
Submitter: Jenkins
Branch: stable/ocata

commit 9aa0915eb85c6b12676b789741a6964d43a60e28
Author: Rob Cresswell <email address hidden>
Date: Thu Jul 13 19:27:22 2017 +0100

    Fix an incorrect policy rule in Admin > Instances

    Change-Id: I765ae0c36d19c88138fbea9545a2ca4791377ffb
    Closes-Bug: #1703066
    (cherry picked from commit 69c81b16e07b67ba0a0bc8e1f55049e7987c5b8c)

[Sean Dague (sdague)]

Found open reviews for this bug in gerrit, setting to In Progress.

review: https://review.openstack.org/481443 in branch: master

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Damon Li (<email address hidden>) on branch: master
Review: https://review.openstack.org/481443

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 11.0.4 release.