The servers group api is called even if the policy disallows it [launch instance modal]

Bug #1702925 reported by Pascal Boutin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Mathieu Gagné

Bug Description

When the "os_compute_api:os-server-groups:discoverable" from the nova policy is disabled, a call is make to this api when the launch instance modal is opened, resulting into an 404 error.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in horizon (Ubuntu):
status: New → Confirmed
affects: horizon (Ubuntu) → horizon
Changed in horizon:
status: Confirmed → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/481682

Changed in horizon:
assignee: nobody → Pascal Boutin (pboutin)
status: New → In Progress
Changed in horizon:
assignee: Pascal Boutin (pboutin) → Mathieu Gagné (mgagne)
Changed in horizon:
milestone: none → pike-3
tags: added: ocata-backport-potential
Changed in horizon:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/481682
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f93c546c141ce2ba4356c5e57c8c5e1663663a83
Submitter: Jenkins
Branch: master

commit f93c546c141ce2ba4356c5e57c8c5e1663663a83
Author: Pascal Boutin <email address hidden>
Date: Fri Jul 7 11:44:04 2017 -0400

    Prevent getServerGroups if the policy disallows it

    The old implementation did not wait for the
    promise to resolve before doing the call, thus
    ignoring the policy.

    Change-Id: I2a7a55ddf287e660371dd6b268953a75afa2a380
    Closes-Bug: #1702925

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b3

This issue was fixed in the openstack/horizon 12.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.