Incorrect message displayed during creation of new secgroup rules if quota exceeded

[Puneet Arora]

Using ocata horizon, I have set quota limit of securitygroup rules to say 2 for admin tenant and now if I try to add security group rules under sec group.
It shows "Error: Security group rule already exists".

Here expected error message should be "Error: Security group rules quota exceeded"

Steps:-
Login to horizon
1) Go to Projects--> Identity--> admin--> manage members--> quota and set secgroup rule to 2.
2) Now goto project--> network-->Security groups--> default-->manage rules--> add rules --> all icmp and select ok.
3) Error message appeared is not correct.

Please correct error message if securitygroup rules quota exhausts and user try to create securitygroup rule under security group.

[Gary W. Smith (gary-w-smith)]

I can reproduce this on Pike.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/534462

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/534462
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3929a8b7cd893f0b4c0ff6c20d5d1fd9077b4dd2
Submitter: Zuul
Branch: master

commit 3929a8b7cd893f0b4c0ff6c20d5d1fd9077b4dd2
Author: Simon Collins <email address hidden>
Date: Wed Jan 17 12:11:15 2018 +1300

    Security group quota error handling

    When adding a new rule to a secruity group that would exceede the
    quota, the error message displays a quota error, rather than rule
    already exists error. It does this my first checking for an
    "OverQuotaClient" error, then if that except doesn't trigger it
    checks for any other conflict

    Change-Id: I8eaa0f00b25c8c3b75fef2bf46979f1f248c6896
    Closes-Bug: #1699724

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/539438

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/539439

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/539439
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5c7aa1422f5328a06528ba5db25732087513f8e4
Submitter: Zuul
Branch: stable/ocata

commit 5c7aa1422f5328a06528ba5db25732087513f8e4
Author: Simon Collins <email address hidden>
Date: Wed Jan 17 12:11:15 2018 +1300

    Security group quota error handling

    When adding a new rule to a secruity group that would exceede the
    quota, the error message displays a quota error, rather than rule
    already exists error. It does this my first checking for an
    "OverQuotaClient" error, then if that except doesn't trigger it
    checks for any other conflict

    Change-Id: I8eaa0f00b25c8c3b75fef2bf46979f1f248c6896
    Closes-Bug: #1699724
    (cherry picked from commit 3929a8b7cd893f0b4c0ff6c20d5d1fd9077b4dd2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/539438
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=97475c085ad18ee8c7719fecd22c1380b01284b8
Submitter: Zuul
Branch: stable/pike

commit 97475c085ad18ee8c7719fecd22c1380b01284b8
Author: Simon Collins <email address hidden>
Date: Wed Jan 17 12:11:15 2018 +1300

    Security group quota error handling

    When adding a new rule to a secruity group that would exceede the
    quota, the error message displays a quota error, rather than rule
    already exists error. It does this my first checking for an
    "OverQuotaClient" error, then if that except doesn't trigger it
    checks for any other conflict

    Change-Id: I8eaa0f00b25c8c3b75fef2bf46979f1f248c6896
    Closes-Bug: #1699724
    (cherry picked from commit 3929a8b7cd893f0b4c0ff6c20d5d1fd9077b4dd2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon ocata-eol release.