OpenStack Dashboard (Horizon)

H405 hacking rule (multi-line docstring)

Bug #1696996 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki
OpenStack Dashboard (Horizon) pike-3

Bug Description

H405 "multi line docstring summary not separated with an empty line" is now disabled in horizon flake8 (pep8 job). We sometimes(?) have comments on docstring format. It is useful to enable this rule.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/472745

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/472746

Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
milestone: next → pike-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/472745
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=95629a337e8aa19fb283cf11a701bd8025b88346
Submitter: Jenkins
Branch: master

commit 95629a337e8aa19fb283cf11a701bd8025b88346
Author: Akihiro Motoki <email address hidden>
Date: Fri Jun 9 16:02:30 2017 +0000

    Fix H405 (multi line docstring) warnings (horizon)

    H405: multi line docstring summary not separated with an empty line

    Partial-Bug: #1696996
    Change-Id: I58f71206def1a25f3eda04b9297f1aa7d3caa646

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/472746
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b9d0243c33dcab1408ecc0661b3fe83d6af9568a
Submitter: Jenkins
Branch: master

commit b9d0243c33dcab1408ecc0661b3fe83d6af9568a
Author: Akihiro Motoki <email address hidden>
Date: Fri Jun 9 10:47:12 2017 +0000

    Fix H405 (multi line docstring) warnings (openstack_dashboard)

    H405: multi line docstring summary not separated with an empty line

    Closes-Bug: #1696996

    Change-Id: Id895695663b19522d9cdc22f8b012e49680d708b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b3

This issue was fixed in the openstack/horizon 12.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.