Repeat method to get instance log

Bug #1693536 reported by wei.ying
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
wei.ying

Bug Description

Env: devstack master branch

Steps to reproduce:
1. Go to project/instances panel
2. Choose an instance and then click its row action View LOG
3. Click Go button to get instance logs
4. Viewing the horizon log or the console, you can see the same request for get instance log.

Reason: the call is repeated with [0] and [1]

[0] https://github.com/openstack/horizon/blob/92f0f23db6afdadafd316df3f323554dd7423752/openstack_dashboard/static/js/horizon.firewalls.js#L24

[1] https://github.com/openstack/horizon/blob/a0d13157e39c452f81d35e7d91a1a9b3a289154a/openstack_dashboard/static/js/horizon.instances.js#L28

wei.ying (wei.yy)
Changed in horizon:
assignee: nobody → wei.ying (wei.yy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/468079

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/468079
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=34caf71d4a3548560debbba4599cd470317ec5a1
Submitter: Jenkins
Branch: master

commit 34caf71d4a3548560debbba4599cd470317ec5a1
Author: wei.ying <email address hidden>
Date: Thu May 18 11:27:01 2017 +0800

    Remove the duplicate method call when retrieving the instance log

    There are two identical ways to get an instance log
    and it should delete the incorrect one.

    [0] openstack_dashboard/static/js/horizon.firewalls.js#L24
    [1] openstack_dashboard/static/js/horizon.instances.js#L28

    Change-Id: I78641f4a5ddf51f905eed1679bb5552529c85e3e
    Closes-Bug: #1693536

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: none → pike-2
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b2

This issue was fixed in the openstack/horizon 12.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.