policy checks for detach_interface not working correctly

Bug #1690790 reported by Kenneth Cummings
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Abdallah Banishamsa

Bug Description

Hello,

we want to prevent non-admin users to detach interfaces from running instances. So we changed the policy to
    "compute:detach_interface": "role:admin",
but still non-admin users see the Option and can use it.

Am I missing some place to declare this option?

Kind regards,
Kenneth Cummings

Revision history for this message
Ying Zuo (yingzuo) wrote :
Changed in horizon:
status: New → Confirmed
Revision history for this message
Ying Zuo (yingzuo) wrote :

As discussed in today's meeting, we should do the same check for this action as in Nova.

Changed in horizon:
importance: Undecided → Medium
milestone: none → next
Changed in horizon:
assignee: nobody → Abdallah Banishamsa (abdallahb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/527414

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/527414
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c999239fed8d2213a8913d1cc8fb294f7086b594
Submitter: Zuul
Branch: master

commit c999239fed8d2213a8913d1cc8fb294f7086b594
Author: Abdallah Banishamsa <email address hidden>
Date: Tue Dec 12 09:25:05 2017 -0500

    Prevent non-admin users from detaching interfaces

    Remove the option to detach_interface from running instances for
    non-admin users.

    Change-Id: Id641bde457e8723ace0bc1e49aab2c46b2227485
    Closes-bug: #1690790

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.0.0b3

This issue was fixed in the openstack/horizon 13.0.0.0b3 development milestone.

Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.