Drop deprecated enable_firewall and enable_vpn settings

[Akihiro Motoki]

enable_firewall and enable_vpn settings in OPENSTACK_NEUTRON_NETWORK were marked as deprecated in Juno release, but they still live in horizon. We now have more consistent way "Pluggable panel" to enable/disable panels and these settings are unnecessary.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/461205

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/461206

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/461205
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b0a5f30248ac905f676f9ad77f1632430a3acc2e
Submitter: Jenkins
Branch: master

commit b0a5f30248ac905f676f9ad77f1632430a3acc2e
Author: Akihiro Motoki <email address hidden>
Date: Sat Apr 29 11:26:45 2017 +0000

    Testing: mock add_panel_mocks() more flexible

    Tis commit enhances openstack_dashboard.test.helpers.TestCase
    .add_panel_mocks() method to more flexible way.
    Now the mock definitions are defined in the test settings and
    setUp() in unit tests and selenium tests sets up mocks defined in
    the test settings TEST_GLOBAL_MOCKS_ON_PANELS.

    This is a preparation for drop of deprecated options (enable_firewall
    and enable_vpn). They were marked as deprecated long ago, but they are
    still kept just because we need a lot of changes in unit tests if dropped.
    By this change, we no longer need to use settings just for testing.

    enable_firewall/enable_vpn=False are dropped (default is True)
    to confirm this change works well.

    Related-Bug: #1687185
    Change-Id: I0a5ebcf8d75e704420d3a5af46fde268a59aa9ec

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/461206
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=53a5164d82a7412d10cee634cd0755336f566e24
Submitter: Jenkins
Branch: master

commit 53a5164d82a7412d10cee634cd0755336f566e24
Author: Akihiro Motoki <email address hidden>
Date: Fri Apr 28 15:35:48 2017 +0000

    Drop deprecated settings: enable_firewall and enable_vpn

    enable_firewall and enable_vpn settings have been deprecated
    since Juno release, but they have not been dropped yet just because
    we need a lot of changes in unit tests if dropped.

    The situation is resolved by the parent commit and we can now drop these
    settings safely. We can control whether a specific panel should be
    enabled or disabled via the pluggable panel mechanism ("enabled" dir).

    Also clean up enable_lb which has gone several releases ago.

    Closes-Bug: #1687185
    Change-Id: I83fa48c5d9568a00294be7cd5f43ef181bc1f28d

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ocata
Review: https://review.openstack.org/545375

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Gutman (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/545375