Python modals are not animated like angular modals

Bug #1669450 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
New
Wishlist
Ivan Kolodyazhny

Bug Description

The Python modals aren't animated like the Angular modals; this is just due to a missing 'fade' class, and is a minor fix.

Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
importance: Undecided → Wishlist
milestone: none → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/440603

Changed in horizon:
status: New → In Progress
tags: added: ocata-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/440603
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8be1ec5e706b07b47f13b8c97c70327b25b09552
Submitter: Jenkins
Branch: master

commit 8be1ec5e706b07b47f13b8c97c70327b25b09552
Author: Rob Cresswell <email address hidden>
Date: Thu Mar 2 14:18:17 2017 +0000

    Add the 'fade' class to Python modals, for animation

    Change-Id: I0547df31529925d9957e704aee167b6b414588c1
    Closes-Bug: 1669450

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to horizon (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/451117

Revision history for this message
Akihiro Motoki (amotoki) wrote :

Resetting the status to New due to the revert.

Changed in horizon:
status: Fix Released → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to horizon (master)

Reviewed: https://review.openstack.org/451117
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=343cbd19b5e4c17c4c4e86fb6ae86cfde95cb84b
Submitter: Jenkins
Branch: master

commit 343cbd19b5e4c17c4c4e86fb6ae86cfde95cb84b
Author: Akihiro Motoki <email address hidden>
Date: Tue Mar 28 23:36:33 2017 +0000

    Revert "Add the 'fade' class to Python modals, for animation"

    After this commit, "Add Rule" in security group panel is not
    setup properly and only a few fields are displayed.
    I haven't identified the root cause but it looks better to
    revert this commit and tackle the original problem again.

    This reverts commit 8be1ec5e706b07b47f13b8c97c70327b25b09552.

    Change-Id: I266484da68dd355082144889699dda299ab9f997
    Closes-Bug: #1677064
    Related-Bug: #1669450

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

Changed in horizon:
milestone: pike-1 → pike-2
Changed in horizon:
milestone: pike-2 → pike-3
Changed in horizon:
milestone: pike-3 → queens-1
Ying Zuo (yingzuo)
Changed in horizon:
milestone: queens-1 → next
Ivan Kolodyazhny (e0ne)
Changed in horizon:
assignee: Rob Cresswell (robcresswell) → Ivan Kolodyazhny (e0ne)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.