Jasmine unit tests view broken by profiler

Bug #1665539 reported by Richard Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Richard Jones

Bug Description

The new profiler dashboard defines an angular constant in the _scripts.html page; this is not reflected in the jasmine.html page, which causes injection to fail during testing when run through the /jasmine URL.

Changed in horizon:
status: New → Triaged
importance: Undecided → High
milestone: none → pike-1
tags: added: ocata-backport-potential
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

And now I'm having trouble reproducing it :-(

Changed in horizon:
status: Triaged → Incomplete
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

I'm back to being able to reproduce it. Jasmine / Chrome does like to use stale files, a lot.

Changed in horizon:
status: Incomplete → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/435251

Changed in horizon:
assignee: nobody → Richard Jones (r1chardj0n3s)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/435251
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0f55a5268f0475687db5566caddf4610cf65ae4b
Submitter: Jenkins
Branch: master

commit 0f55a5268f0475687db5566caddf4610cf65ae4b
Author: Richard Jones <email address hidden>
Date: Fri Feb 17 15:57:17 2017 +1100

    Define profiler constant to fix /jasmine test run

    Change-Id: Ie7aa0e1652b02ccbd9d1f3a776a041ecd3e1aa9b
    Closes-Bug: 1665539

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/445409

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/ocata)

Reviewed: https://review.openstack.org/445409
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=09417eb149c944d188000f8c823bc0aab4e080c4
Submitter: Jenkins
Branch: stable/ocata

commit 09417eb149c944d188000f8c823bc0aab4e080c4
Author: Richard Jones <email address hidden>
Date: Fri Feb 17 15:57:17 2017 +1100

    Define profiler constant to fix /jasmine test run

    Change-Id: Ie7aa0e1652b02ccbd9d1f3a776a041ecd3e1aa9b
    Closes-Bug: 1665539
    (cherry picked from commit 0f55a5268f0475687db5566caddf4610cf65ae4b)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.2

This issue was fixed in the openstack/horizon 11.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.