while I choosing “volume” for “image source” , "Type" can't be hide

Bug #1658383 reported by hanwei
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Richard Jones

Bug Description

the problem is found in newton-master

while creating volume, because of the "class" of "image source" lack of "switchable", while I choosing “volume” for “image source” , "Type" can't be hide.

I think that there is something error here in the file"horizon/templates/horizon/common/fields/_themable_select.html":
  <select
    {% if id %}
      id="{{ id }}"{% endif %}
    {% if name %}
      name="{{ name }}"
    {% endif %}
    {% for k,v in select_attrs.items %}
      {% if k != 'class' %}
        {{ k|safe }}="{{ v }}"
      {% endif %}
    {% endfor %}

class="form-control switchable" will not be set to "image source", something is modified like this, it's Ok:
  <select
    {% if id %}
      id="{{ id }}"{% endif %}
    {% if name %}
      name="{{ name }}"
    {% endif %}
    {% for k,v in select_attrs.items %}
      {% if k != 'class' or 'switch' in v %}
        {{ k|safe }}="{{ v }}"
      {% endif %}
    {% endfor %}

Changed in horizon:
status: New → Triaged
importance: Undecided → Medium
milestone: none → pike-1
tags: added: newton-backport-potential ocata-backport-potential
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

Thanks for the report and fix!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/435858

Changed in horizon:
assignee: nobody → Richard Jones (r1chardj0n3s)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/435858
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=56cc9ce14d5d84da562c282e672aedc57dd4dca6
Submitter: Jenkins
Branch: master

commit 56cc9ce14d5d84da562c282e672aedc57dd4dca6
Author: Richard Jones <email address hidden>
Date: Mon Feb 20 16:59:32 2017 +1100

    Fix hiding of selects when switchable

    Change-Id: I6e6ddefa6f1dcef6b8f1500ec5f09e73d3f0545f
    Closes-Bug: 1658383

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/443091

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/ocata)

Reviewed: https://review.openstack.org/443091
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5701a15f822620618bbe64baa91e7843fe3e7fab
Submitter: Jenkins
Branch: stable/ocata

commit 5701a15f822620618bbe64baa91e7843fe3e7fab
Author: Richard Jones <email address hidden>
Date: Mon Feb 20 16:59:32 2017 +1100

    Fix hiding of selects when switchable

    Change-Id: I6e6ddefa6f1dcef6b8f1500ec5f09e73d3f0545f
    Closes-Bug: 1658383
    (cherry picked from commit 56cc9ce14d5d84da562c282e672aedc57dd4dca6)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.1

This issue was fixed in the openstack/horizon 11.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.