volume backups fail if no container name provided

Bug #1658137 reported by Eric Peterson
16
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Undecided
Unassigned
OpenStack Dashboard (Horizon)
Fix Released
High
Eric Peterson

Bug Description

if no container name is provided, horizon ends up passing "" to the cinder client api call. This is an invalid container name - None is the correct value to pass for this to work as desired.

Changed in horizon:
assignee: nobody → Eric Peterson (ericpeterson-l)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/424261

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/424261
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=90a9af2e0b4524b4dec1caafbb6159cb587878d4
Submitter: Jenkins
Branch: master

commit 90a9af2e0b4524b4dec1caafbb6159cb587878d4
Author: Eric Peterson <email address hidden>
Date: Mon Jan 23 10:39:52 2017 -0700

    Autogenerate container name correctly for vol backup

    The volume backup code is passing '' as a default container name,
    which will cause cinder/swift to fail. If no container name is provided,
    the default value of None will enable the auto creation of a container correctly.

    Change-Id: I7813153c65652ce6e1a5ac03204a8738eefdc64e
    Closes-Bug: #1658137

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/424634

Revision history for this message
Adrien Cunin (adri2000) wrote :

There was already a bug report (bug #1603647) as well as a patch WiP.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/424634
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3238dc0738952b54871d214fbddbe1b33ed9fc84
Submitter: Jenkins
Branch: stable/newton

commit 3238dc0738952b54871d214fbddbe1b33ed9fc84
Author: Eric Peterson <email address hidden>
Date: Mon Jan 23 10:39:52 2017 -0700

    Autogenerate container name correctly for vol backup

    The volume backup code is passing '' as a default container name,
    which will cause cinder/swift to fail. If no container name is provided,
    the default value of None will enable the auto creation of a container correctly.

    Change-Id: I7813153c65652ce6e1a5ac03204a8738eefdc64e
    Closes-Bug: #1658137
    (cherry picked from commit 90a9af2e0b4524b4dec1caafbb6159cb587878d4)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b3

This issue was fixed in the openstack/horizon 11.0.0.0b3 development milestone.

Changed in horizon:
milestone: none → ocata-3
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.2

This issue was fixed in the openstack/horizon 10.0.2 release.

wangxiyuan (wangxiyuan)
Changed in cinder:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.