Dropdown covered by modal footer

Bug #1655201 reported by Thai Tran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
In Progress
Wishlist
Akihiro Motoki

Bug Description

The dropdown menu inside of a modal dialog is now below the modal footer. This makes it extremely frustrating to select a menu item. The user has to scrolls inside of the modal dialog in order to get to an item.

Take a look at the identity users table and try to create a new user. At the bottom, select a Role. Notice that the dropdown is cut off.

Thai Tran (tqtran)
description: updated
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

I believe https://review.openstack.org/#/c/341945/ is necessary to reproduce this bug.

Revision history for this message
Thai Tran (tqtran) wrote :

Actually, I am seeing this on master in the django users panel. As stated in the description, its a modal issue and has nothing to do with users panel. I am only using it as an example.

Changed in horizon:
status: New → Triaged
importance: Undecided → Wishlist
importance: Wishlist → Medium
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

Verified.

Yes, the contents have to scroll if they're too long to fit the modal's max height. I don't believe we can do anything differently here, but I'm marking this as a "wishlist" item in case you have an idea :-)

Changed in horizon:
importance: Medium → Wishlist
milestone: none → next
daijing (daijing)
Changed in horizon:
assignee: nobody → daijing (daijing)
daijing (daijing)
Changed in horizon:
assignee: daijing (daijing) → nobody
Revision history for this message
Akihiro Motoki (amotoki) wrote :

It's frustrating me a lot especially in a small modal form.

We specify overflow-y: auto [1] and as a result if a drop down menu is larger than a modal the menu is hidden and we need to scroll it. Changing this to 'visible', we can see a drop down menu outside of a modal.

[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/dashboard/scss/components/_modals.scss#L2

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Screenshot after changing modal 'overflow-y' attribute to 'visible'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/460929

Changed in horizon:
status: Triaged → In Progress
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → pike-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/460929
Reason: https://review.openstack.org/#/c/389866/ already try to fix the same problem.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

The current modal form is like this.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.