Shared checkbox in networks should not be shown if non-admin users are not allowed to touch.

[Han Chao]

Currently, an admin user is allowed by the policy to create or update a network with the attribute of 'shared' checkbox during the creating workflow or the updating form. However, a non-admin user is not allowed by the policy to create or update the 'shared' attribute for the network.

The current implementation for non-admin users of this process is to present the 'shared' checkbox. This checkbox is disabled, namely not allowed to touch, and with help text of 'Non admin users are not allowed to set shared option.'.

By function point of view, this is correct with no problem. But from my opinion, non-admin users would try to tick the checkbox and then see that it is not allowed by the help text. This makes non-admin users confused. If this is not allowed to use by non-admin users, why not just make it invisible to non-admin users.

This is my concern to improve the use case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413380

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413380
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c9034ec7ae2155db3e746818537bdd4932cb44d1
Submitter: Jenkins
Branch: master

commit c9034ec7ae2155db3e746818537bdd4932cb44d1
Author: hanchao <email address hidden>
Date: Wed Dec 21 11:00:46 2016 +0800

    Remove shared checkbox for non-admin users when doing network things.

    Non-admin users are not allowed to touch the 'shared' checkbox when
    creating or updating networks. It is better to make this invisible
    to non-admin users instead of presenting it but not allowed to touch.

    Change-Id: Ia5ed186b22f8658866c3a2b2acdde8053d176d81
    Closes-Bug: #1651626

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 11.0.0.0rc1 release candidate.