Skip flavor's disk check when booting from volume

[Mate Lakat]

To reproduce:
 - Have an image which specifies minDisk as non-zero:
   wget http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img
   glance image-create --name testimg-explicit-mindisk --min-disk 1 --disk-format=qcow2 --file cirros-0.3.4-x86_64-disk.img --container-format=bare
 - Have a flavor which has a zero disk requirement:
   nova flavor-create --ephemeral 0 --swap 0 tstflav tstflav 512 0 1

On Horizon follow these steps:
 - Instances -> Launch Instance
 - Give a name for the instance, move to Source tab
 - Boot source is image, select yes to create a volume
 - Select testimg-explicit-mindisk for image
 - Move to Flavor tab

See that flavors with 0 disk (like `tstflav`) cannot be selected.

The yellow triangle shows the following message:

The selected image source requires a flavor with at least 1 GB of root disk. Select a flavor with a larger root disk or use a different image source.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/393250

[Mate Lakat (mate-lakat)]

The same thing happens on Liberty, but the UI is different - as it is not using the new angular workflow.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/396685

[Mateusz Kowalski (makowals)]

I have no idea why assignee was changed (sorry, new into launchpad), but the review I've created is "on top" of Mate's, not instead

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mateusz Kowalski (<email address hidden>) on branch: master
Review: https://review.openstack.org/396685
Reason: Amended the change into #393250 -- makes more sense to have it as a big one

[Ying Zuo (yingzuo)]

Bug 1643100 reported other issues related to flavors with zero disk. If those issues will be resolved in this ticket, please mark that as a duplicate. Thanks.

https://bugs.launchpad.net/horizon/+bug/1643100

[Ying Zuo (yingzuo)]

Opened bugs #1643953 and #1643954 as per discussion on https://review.openstack.org/#/c/393250.

[Mate Lakat (mate-lakat)]

Ying, Reading your comments on the proposed change - If I understand correctly, what you are suggesting is that if a flavor's disk size is zero, no disk-size check should be performed regardless of booting from volume or from image. That seems to align with the official documentation: http://docs.openstack.org/admin-guide/compute-flavors.html

I would say let's file a new ticket for that, and modify this ticket's description to:
- Skip Flavor's disk check when booting from volume

And the new bug's description should be:
- Don't check flavors with zero root disk

Ideas?

[Ying Zuo (yingzuo)]

Mate,
That's correct. Flavor with zero disk is a special case and should not be blocked by the disk size check. I will open a new defect then.

[Ying Zuo (yingzuo)]

I reopened the original ticket https://bugs.launchpad.net/horizon/+bug/1643100.

[Mate Lakat (mate-lakat)]

looking at the future: Please also see this blueprint: http://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/flavor-root-disk-none.html

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Jones (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/396063
Reason: We are no longer patching Liberty.

[Mateusz Kowalski (makowals)]

This is the current patch for master -- https://review.openstack.org/#/c/393250/

[Chris Wright (chwright)]

Wondering the status of this fix - I believe the correct result should be the flavor check should ignore the configured root disk size when a cinder volume is being used for the boot/root drive. Through the API you can use a flavor / image combination with any root drive size configured on the flavor when a cinder volume is used instead (as long as the cinder volume is large enough to fit the chosen image) - however horizon incorrectly prohibits this with its validation checks.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/393250
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.