Horizon checks a neutron policy.json action that does not exists - "remove_router" doesn't exists in the neutron policy.json

Bug #1638344 reported by Rick Bartra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
High
Unassigned

Bug Description

Horizon checks the "remove_router" neutron action which doesn't exists in the neutron policy.json.
Neutron also doesn't check the "remove_router" action in the policy.json when performing the "neutron firewall-update <firewall_id> --no-routers" CLI command.

Horizon policy check: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/firewalls/tables.py#L251

Neutron policy file in Horizon: https://github.com/openstack/horizon/blob/master/openstack_dashboard/conf/neutron_policy.json

Neutron policy file in Neutron:
https://github.com/openstack/neutron/blob/master/etc/policy.json

Rick Bartra (rb560u)
Changed in horizon:
assignee: nobody → Rick Bartra (rb560u)
Changed in horizon:
status: New → Triaged
importance: Undecided → High
milestone: none → ocata-2
tags: added: newton-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/399673

Changed in horizon:
status: Triaged → In Progress
Changed in horizon:
milestone: ocata-2 → ocata-rc1
Changed in horizon:
milestone: ocata-rc1 → next
tags: added: ocata-backport-potential
Rick Bartra (rb560u)
Changed in horizon:
assignee: Rick Bartra (rb560u) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Rick Bartra (<email address hidden>) on branch: master
Review: https://review.openstack.org/399673

Changed in horizon:
milestone: next → none
status: In Progress → Invalid
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Invalid means this is not a bug. If we would like to expire a bug, I believe "Incomplete" would be fine.

On the other hand, looking at the bug report and the proposed change, it looks a valid bug.
I think something wrong was made during the enforcement of policy in horizon.

While I was not aware of this until the bug is marked as Invalid, it looks a bug. Horizon has been shipped with FWaaS support for a while, but actually there are few reviewers who understand the reality of FWaaS and it looks a time that FWaaS team provides its supports by themselves. I can support the effort.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/399673
Reason: "restore" might be wrong.

Let me abandon this again. I was not aware of the change until it was abandoned. While activity of FWaaS team was revived in the neutron community, I am not sure we need to restore FWaaS v1 activity now. If we need to revive the change, more involvement of FWaaS team is required. In addition, I wonder who wants to keep FWaaS v1 support, Anyway if you have a thought on this, feel free to reach me. I will coordinate the effort of supporting FWaaS and can discuss the future support with neutron FWaaS team.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.