UX: Alert message in "Create Network" Modal does not have col-* class

Bug #1632109 reported by Eddie Ramirez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
ChangBo Guo(gcb)

Bug Description

How to reproduce:
1. Go to Project->Networks
2. Click on "Create Network" button.
3. Do not fill in the form
4. Go to tab "Subnet" then click on tab "Subnet details"
5. See how the alert message fills the 100% of the width of the modal, when it should have margin both left and right.

The alert box should be inside a col-*-12 class.

Revision history for this message
Eddie Ramirez (ediardo) wrote :
Changed in horizon:
status: New → Confirmed
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

This is really a much bigger problem with the validation on that modal :/

Changed in horizon:
importance: Undecided → Low
tags: added: low-hanging-fruit
Changed in horizon:
milestone: none → next
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/398328

Changed in horizon:
assignee: nobody → braveliuchina (braveliuchina)
Revision history for this message
anusha (anusha) wrote :

same changes we are also applying but horizon changes are applied.(horizon.modals.js file is not included)

horizon/horizon/static/horizon/js/horizon.modals.js changes is not applied in devstack.

anusha (anusha)
Changed in horizon:
assignee: braveliuchina (braveliuchina) → anusha (anusha)
siva (r.siva)
Changed in horizon:
assignee: anusha (anusha) → siva (r.siva)
anusha (anusha)
Changed in horizon:
assignee: siva (r.siva) → anusha (anusha)
anusha (anusha)
Changed in horizon:
assignee: anusha (anusha) → nobody
Changed in horizon:
assignee: nobody → ChangBo Guo(gcb) (glongwave)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/398328
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=46c2ad601ce20827b02c3e0c4a1ad4f1400a1f0b
Submitter: Jenkins
Branch: master

commit 46c2ad601ce20827b02c3e0c4a1ad4f1400a1f0b
Author: braveliuchina <email address hidden>
Date: Wed Nov 16 20:20:41 2016 +0800

    Add col-sm-12 to network modal error

    This patch adds a missing bootstrap col class to the errors
    that show in the create/update network and subnet modals.

    Change-Id: I82460db791c7da579f0f0379ea2e44599e000d0e
    Closes-Bug: 1632109

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b3

This issue was fixed in the openstack/horizon 11.0.0.0b3 development milestone.

Changed in horizon:
milestone: next → ocata-3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.