i18n: duplicate 'translate' marking in theme-preview.html

Bug #1624751 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

There are duplicated and nested 'translated' mark in theme-preview.html.

               <div class="col-lg-10">
                 <div class="themable-radio">
                   <input type="radio" name="optionsThemableRadios" id="optionsRadios3" value="option1" checked="">
                   <label translate for="optionsRadios3">
                     <span>{$ 'Themable Option 1' | translate $}</span>
                   </label>
                 </div>
                 <div class="themable-radio">
                   <input type="radio" name="optionsThemableRadios" id="optionsRadios4" value="option2">
                   <label translate for="optionsRadios4">
                    <span>{$ 'Themable Option 2' | translate $}</span>
                   </label>
                 </div>

As a result, we have the following entries in PO files.

<span>{$ 'Themable Option 1' | translate $}</span>
<span>{$ 'Themable Option 2' | translate $}</span>

Themable Option 1/2 should be extracted.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

The strings are in Developer Dashboard, so it can be low priority.
newton backport is optional, so I don't add newton-rc-potential tag.

Changed in horizon:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/371986

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/371986
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4340fc25fe618e849771e7cbca54b8b3383df3e5
Submitter: Jenkins
Branch: master

commit 4340fc25fe618e849771e7cbca54b8b3383df3e5
Author: Akihiro Motoki <email address hidden>
Date: Sat Sep 17 21:33:21 2016 +0000

    Remove duplicated inappropriate 'translate' tag

    Change-Id: Id07287e20760116285cb5fda86aac272b8d06e35
    Closes-Bug: #1624751

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b1

This issue was fixed in the openstack/horizon 11.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/420803

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/420803
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a8423e026e2f15d0806f158b642a992249ede13e
Submitter: Jenkins
Branch: stable/newton

commit a8423e026e2f15d0806f158b642a992249ede13e
Author: Akihiro Motoki <email address hidden>
Date: Sat Sep 17 21:33:21 2016 +0000

    Remove duplicated inappropriate 'translate' tag

    Change-Id: Id07287e20760116285cb5fda86aac272b8d06e35
    Closes-Bug: #1624751
    (cherry picked from commit 4340fc25fe618e849771e7cbca54b8b3383df3e5)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.2

This issue was fixed in the openstack/horizon 10.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.