i18n: Cannot control word order of message in Delete Dialog

Bug #1624197 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

When deleting a resource, the confirm form is displayed. In the form, we have a message 'You have selected "net1".' but "You have selected" and a resource name is concatenated in the django template. In some language, an object is placed before a verb, but translators cannot control the word order.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/371268

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/371268
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cf5650f7f18ca3bb36a6c8c2c3802532b1bc882f
Submitter: Jenkins
Branch: master

commit cf5650f7f18ca3bb36a6c8c2c3802532b1bc882f
Author: Akihiro Motoki <email address hidden>
Date: Fri Sep 16 04:26:49 2016 +0000

    Allow translator to control word order in delete confirm dialog

    Change-Id: I82c27d21cb000602e1cf76313c2cdec680c45394
    Closes-Bug: #1624197

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Rob Cresswell (robcresswell) wrote :

@amotoki: Did you intend for this to be in stable/newton for the translators? I thought hard string freeze would prevent a backport here.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

Yes, I would like to have it in stable/newton. This is a feedback from translation.

I know we are in hard string freeze, so the recommended process is to post this to i18n list and get ack from them. I will do it.

tags: added: newton-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/371907

Revision history for this message
Rob Cresswell (robcresswell) wrote :

Sounds good. I'm happy to accept this from the Horizon side as long as i18n is happy.

Revision history for this message
Akihiro Motoki (amotoki) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/371907
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f55f1d88e246a26d71e84b53e2a85c5ca89c53ed
Submitter: Jenkins
Branch: stable/newton

commit f55f1d88e246a26d71e84b53e2a85c5ca89c53ed
Author: Akihiro Motoki <email address hidden>
Date: Fri Sep 16 04:26:49 2016 +0000

    Allow translator to control word order in delete confirm dialog

    Change-Id: I82c27d21cb000602e1cf76313c2cdec680c45394
    Closes-Bug: #1624197
    (cherry picked from commit cf5650f7f18ca3bb36a6c8c2c3802532b1bc882f)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.0.0rc2

This issue was fixed in the openstack/horizon 10.0.0.0rc2 release candidate.

Akihiro Motoki (amotoki)
tags: removed: newton-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b1

This issue was fixed in the openstack/horizon 11.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers