Dont' reinitalize themable selects once they've been initialized

Bug #1617001 reported by Diana Whitten
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Medium
Unassigned

Bug Description

init_themable_select should only work on things that have not already been initialized.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/360679

Changed in horizon:
milestone: newton-rc1 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/360679
Reason: Abandoned due to inactivity. Please feel free to restore if you wish to work on it.

Changed in horizon:
status: In Progress → Confirmed
assignee: Diana Whitten (hurgleburgler) → nobody
tags: added: low-hanging-fruit
Changed in horizon:
status: Confirmed → Triaged
Gloria Gu (gloria-gu)
Changed in horizon:
assignee: nobody → Gloria Gu (gloria-gu)
Changed in horizon:
status: Triaged → In Progress
Revision history for this message
Jeremy Moffitt (jeremy-moffitt) wrote :

I tried testing the proposed fix for this and found that the problem ascribed here never actually occurs. The "if" statement in the is always true and only hits once per page load. I'm trying to track down additional information about the ticket, but this may be an unnecessary fix for a non-existent problem.

Revision history for this message
Gloria Gu (gloria-gu) wrote :

What the change Diana put there doesn't seem to have effect. So mark this invalid.

Changed in horizon:
status: In Progress → Invalid
assignee: Gloria Gu (gloria-gu) → nobody
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/360679
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.