'can_set_password' ignored in the new launch instance experience

Bug #1609777 reported by massimo.sgaravatto
52
This bug affects 10 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Unassigned

Bug Description

In the legacy launch instance experience users can set the admin password of the instance, if 'can_set_password' is true in local_settings.

In the new launch instance experience this is not possible

Environment: OpenStack Mitaka on CentOS7

Tags: nova pike
description: updated
Akihiro Motoki (amotoki)
Changed in horizon:
status: New → Confirmed
tags: added: mitaka-backport-potential newton-backport-potential
Changed in horizon:
importance: Undecided → Medium
milestone: none → ocata-1
Changed in horizon:
milestone: ocata-1 → ocata-2
Changed in horizon:
status: Confirmed → Fix Released
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Why was this set to Fix Released with no linked patch? Please link relevant content so the bug team can do their jobs.

Changed in horizon:
status: Fix Released → Confirmed
Changed in horizon:
milestone: ocata-2 → next
Revision history for this message
Robert T (robetus) wrote :

This has not been fixed in Ocata, just confirmed by install.

Revision history for this message
Mathieu Gagné (mgagne) wrote :

Suppose someone wants to work on this feature. In which step should the password field be located?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/492546

Changed in horizon:
assignee: nobody → Pascal Boutin (pboutin)
status: Confirmed → In Progress
Revision history for this message
Akihiro Motoki (amotoki) wrote :

This is still valid, but mitaka is EOL and newton now receives critical and security fixes only, so bug tags have been updated.

tags: removed: mitaka-backport-potential newton-backport-potential
Akihiro Motoki (amotoki)
tags: added: nova
Revision history for this message
Dmitriy Rabotyagov (noonedeadpunk) wrote :

Hi,

I have exactly the same problem in the Pike release. Moreover, requires_keypair doesn't work in the new interface as well. I've found, that /usr/share/openstack-dashboard/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/keypair.controller.js should be responsible for redering this menu. On lines 99-101 there are lines, which should retrieve from configuration:

settingsService.getSetting(
  'OPENSTACK_HYPERVISOR_FEATURES.requires_keypair'
).then(setKeypairRequired);

So we've tried to debug function setKeypairRequired() by adding alert(setting) in it, and setting was equal to True. Nevertheless option is not marked as required one.

Thanks in advance.

tags: added: pike
Revision history for this message
Akihiro Motoki (amotoki) wrote :

This bug is about can_set_password. 'requires_keypairs' should be handled as a separate bug.

Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → rocky-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/492546
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Akihiro Motoki (amotoki) wrote :
Changed in horizon:
status: In Progress → Fix Released
milestone: rocky-2 → none
assignee: Pascal Boutin (pboutin) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 19.1.0

This issue was fixed in the openstack/horizon 19.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.