Horizon ignores instance snapshot as pre-selected source image

[[e-mail]]

Description of problem:
When launching an instance from an instance snapshot via Horizon images overview (Button "Launch") the resulting "Launch instance"-dialog ignores the selected image, the source has to be selected again. This only affects "Instance Snapshot" as source type, the other source types (Image, Volume, Volume Snapshot) are accepted.

Versions:
OpenStack Mitaka on openSUSE_Leap_42.1
openstack-dashboard-9.0.2~a0~dev22-1.1.noarch

How reproducible:
Every time

Steps to Reproduce:
1. Create a snapshot from a running instance.
2. From the images overview (http://control/project/images/) click on the new image (instance snapshot).

Actual result:
In the "Launch Instance"-dialog no image is selected in the "Source" tab and it's marked with an asterisk, an image has to be selected (again).

Expected result:
The form field in "Source" should be pre-allocated by the instance snapshot and "Source" should not be marked by an asterisk.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/350291

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/350291
Reason: Abandoned due to inactivity. Please feel free to restore if you wish to work on it.

[[e-mail] (eblock)]

I applied the changes proposed in [1], and they worked for me. Unfortunately, this issue is evolving similar to a bug I have reported over a year ago [2]. The changes in

/srv/www/openstack-dashboard/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js

and

/srv/www/openstack-dashboard/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.spec.js

don't resolve the issue, snapshots are not pre-selected anymore. So I applied the exact same changes to these files:

/srv/www/openstack-dashboard/static/dashboard/project/workflow/launch-instance/source/source.controller.js
/srv/www/openstack-dashboard/static/dashboard/project/workflow/launch-instance/source/source.controller.spec.js

and this works now as expected.
Newton release seems to have the same issue.

[1] https://review.openstack.org/#/c/350291/
[2] https://bugs.launchpad.net/nova/+bug/1560965

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/600399

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600399
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=87f5e21b03bdb9a1a09a587f2a3176cc094529b8
Submitter: Zuul
Branch: master

commit 87f5e21b03bdb9a1a09a587f2a3176cc094529b8
Author: David Gutman <email address hidden>
Date: Thu Sep 6 11:33:09 2018 +0200

    Select correct boot source when launching instance from different sources

    When launching instance from snapshot, volume or volume snapshot,
    the selected boot source was always image.
    This was due to a reset to image boot source when receiving "change allowed boot
    sources" event.
    From now:
     - The "change allowed boot source" event does not flush a preselection
    if the preselection boot source type is in the allowed sources.
     - Set the bootsource with preselection update correctly the form for each
    different type of boot source.

    Change-Id: I6907652731fa89b303d997fe2e3c331a68f085b6
    Closes-bug: #1608565

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 15.0.0.0b1 development milestone.