Some explanation of permissions 'my.openstack.permission'?

Bug #1605842 reported by zzxwill
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Amelia Cordwell

Bug Description

In this link http://docs.openstack.org/developer/horizon/quickstart.html, there is no explanation for permission 'my.openstack.permission' in section Panel while this is important for doc readers, especially for a developer who would like to customize permissions. Thanks.

class Images(horizon.Panel):
    name = "Images"
    slug = 'images'
    permissions = ('openstack.roles.admin', 'my.openstack.permission',)
    policy_rules = (('endpoint', 'endpoint:rule'),)

Revision history for this message
zzxwill (zzxwill) wrote :

I looked through docs on openstack.org and didn't find much information on it. I intend to explain it a little bit with an example. Thanks.

Changed in horizon:
assignee: nobody → zzxwill (zzxwill)
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Removed assignee due to inactivity.

tags: added: documentation low-hanging-fruit
Changed in horizon:
milestone: none → next
importance: Undecided → Low
status: New → Confirmed
assignee: zzxwill (zzxwill) → nobody
Changed in horizon:
assignee: nobody → Amelia Cordwell (ameliacordwell)
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Amelia Cordwell (ameliacordwell) wrote :

I had a look into this and into the django_openstack_auth code, and it seems that a permission like the second example will never be used, the only permissions the keystone backend sets against are of the form openstack.roles.role_name and openstack.services.service_name. I modified the example and added a short explanation. Patch: https://review.openstack.org/#/c/500653/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/500653
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4d32b1fbe9107c1474944794fe3e1876ad21dc1d
Submitter: Zuul
Branch: master

commit 4d32b1fbe9107c1474944794fe3e1876ad21dc1d
Author: Amelia Cordwell <email address hidden>
Date: Tue Sep 5 13:44:17 2017 +1200

    Add permissions explanation to quickstart doc

    * Also fixes part of the example which showed having a custom
      permission that could not exist in the way that
      django_openstack_auth's keystone backend was implemented.

    Change-Id: I46e748302d34f82648ef6690e2d5db4618487a6a
    Closes-Bug: #1605842

Changed in horizon:
status: In Progress → Fix Released
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → queens-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.0.0b1

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.