Destructive buttons on modal should be red

Bug #1599262 reported by Ying Zuo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Ying Zuo

Bug Description

The destructive buttons in table are styled to be red to give the user a warning to process.
The destructive buttons on confirmation modal don't have this styling but they should be consistent everywhere.

For example, when you try to delete one instance, the Terminate Instance action in the action menu is red when it's hovered. If the user selected multiple instances, the Terminate Instances action above the table has the same styling but the Terminate button on the confirmation modal doesn't have the same styling.

Revision history for this message
Ying Zuo (yingzuo) wrote :
Changed in horizon:
assignee: nobody → Ying Zuo (yingzuo)
Changed in horizon:
milestone: none → next
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/339278

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Ying Zuo (yingzuo) wrote :

Attached a screenshot with the patch above.

Changed in horizon:
assignee: Ying Zuo (yingzuo) → nobody
assignee: nobody → Hansel Thomas (hansel.thomas)
assignee: Hansel Thomas (hansel.thomas) → nobody
Ying Zuo (yingzuo)
Changed in horizon:
assignee: nobody → Ying Zuo (yingzuo)
Changed in horizon:
assignee: Ying Zuo (yingzuo) → Rob Cresswell (robcresswell)
Changed in horizon:
assignee: Rob Cresswell (robcresswell) → Ying Zuo (yingzuo)
Ying Zuo (yingzuo)
Changed in horizon:
milestone: next → queens-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/339278
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7f6e03a4dda5a502d31e3d19798b710ca9a182eb
Submitter: Zuul
Branch: master

commit 7f6e03a4dda5a502d31e3d19798b710ca9a182eb
Author: Ying Zuo <email address hidden>
Date: Thu Jul 7 16:36:28 2016 -0700

    Fix style of the submit button on confirmation modal

    If the action is destructive, the submit button on the confirmation
    modal should be red.

    Change-Id: I5d561bce70861eb1465a0f79f9496167a4fb4043
    Closes-bug: #1599262

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.0.0b2

This issue was fixed in the openstack/horizon 13.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.