Horizon Forms should allow themable number spinners

Bug #1598311 reported by Diana Whitten
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Jeremy Moffitt

Bug Description

Much like the themable selects and checkboxes, number spinners should also be themable.

Tags: branding
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/337936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Diana Whitten (<email address hidden>) on branch: master
Review: https://review.openstack.org/337936

Changed in horizon:
assignee: Diana Whitten (hurgleburgler) → Travis Tripp (travis-tripp)
Changed in horizon:
assignee: Travis Tripp (travis-tripp) → Diana Whitten (hurgleburgler)
Changed in horizon:
assignee: Diana Whitten (hurgleburgler) → nobody
status: In Progress → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/337936
Reason: Abandoned due to inactivity. Feel free to restore if you have time to work on it

Gloria Gu (gloria-gu)
Changed in horizon:
assignee: nobody → Gloria Gu (gloria-gu)
Changed in horizon:
assignee: Gloria Gu (gloria-gu) → Jeremy Moffitt (jeremy-moffitt)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/337936
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1f11a792797dc422fb9e929b1480a0c4abace25c
Submitter: Jenkins
Branch: master

commit 1f11a792797dc422fb9e929b1480a0c4abace25c
Author: Diana Whitten <email address hidden>
Date: Tue Jul 5 17:46:09 2016 -0700

    Horizon Forms should allow themable number spinners

    Much like the themable selects and checkboxes, number spinners
    should also be themable.

    Standard number spinners are not very customizable. We should use
    existing buttons and fonts to add their functionality to allow a
    richer experience if desired downstream.

    An example of how to customize the spinner was placed in Material.
    The example shows how to use flexbox to change layout type from
    column to row, change icon order, and how to override the icons.

    'autocomplete' needs to be false on this new element, otherwise
    the browser will retain and load the last value without actually
    triggering any JavaScript events by which we can key on and update
    the state of the spinner buttons.

    Change-Id: Ifd266cd515a903841e2d28e2f4731879116e3513
    Closes-bug: #1598311

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b3

This issue was fixed in the openstack/horizon 12.0.0.0b3 development milestone.

Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.