Port Validator Failing

[Ankur]

A recent update to netutils allows users to select port number 0. This change is causing the below to fail.

======================================================================
FAIL: test_port_range_validator (horizon.test.tests.utils.ValidatorsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/stack/horizon/horizon/test/tests/utils.py", line 257, in test_port_range_validator
    self.assertRaises(ValidationError, test_call, prange)
AssertionError: ValidationError not raised

======================================================================
FAIL: test_port_validator (horizon.test.tests.utils.ValidatorsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/stack/horizon/horizon/test/tests/utils.py", line 207, in test_port_validator
    port)
AssertionError: ValidationError not raised

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329777

[Matthias Runge (mrunge)]

The change causing this failure is https://github.com/openstack/oslo.utils/commit/98e24bedf35231431da6924ce7eee05b8a7cbec1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329777
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=68ce548f8193e1b29475f1ed4d0d6c2506a1ffab
Submitter: Jenkins
Branch: master

commit 68ce548f8193e1b29475f1ed4d0d6c2506a1ffab
Author: Matthias Runge <email address hidden>
Date: Wed Jun 15 08:48:45 2016 +0200

    Fix port validator

    A recent change in netutils now allows a port number 0
    as valid port number. This made tests fail.

    Change-Id: Ic290b76daa59387d8a13ce3712f7cd9416ac80c5
    Closes-bug: #1592553

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/329954

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthias Runge (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/329954
Reason: squashed together with https://review.openstack.org/329145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329145
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e749628a136ca71cfc443df629bbd115cb5437b1
Submitter: Jenkins
Branch: stable/mitaka

commit e749628a136ca71cfc443df629bbd115cb5437b1
Author: Timur Sufiev <email address hidden>
Date: Thu Jun 9 21:59:15 2016 +0300

    Hotfix the issue with too new Firefox version

    which Selenium WebDriver cannot connect to.

    This commit squashes *two* commits, to be able to merge.
    Both patches already landed in master.

    Partial-Bug: 1590939
    (cherry picked from commit 6f17650a3ac44fc112ce363473e520702a0eb8b5)

    Fix port validator

    A recent change in netutils now allows a port number 0
    as valid port number. This made tests fail.

    Closes-bug: #1592553
    (cherry picked from commit 68ce548f8193e1b29475f1ed4d0d6c2506a1ffab)

    Change-Id: Ide1de4638b9c8b3e0ec1d34f7c044e8a96cc5890

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 9.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 9.1.0 release.