OpenStack Dashboard (Horizon)

new launch instance wizard defaults

Bug #1587681 reported by Kevin Fox
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Kevin Fox
OpenStack Dashboard (Horizon) newton-1 "n1"

Bug Description

In Mitaka, the new launch instance wizard regresses functionality from the old launch wizard with regards to defaults. If there is only one neutron network, it is not automatically selected, if there is only one keypair, its not selected, and the default security group is not automatically selected.

Revision history for this message
Kevin Fox (kevpn) wrote :

I've got a patch for this... will upload soon.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/323623

Changed in horizon:
assignee: nobody → Kevin Fox (kevpn)
status: New → In Progress
Brad Pokorny (bpokorny)
tags: added: mitaka-backport-potential
Matthias Runge (mrunge)
Changed in horizon:
importance: Undecided → Medium
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
milestone: none → newton-2
Matt Borland (palecrow)
tags: added: angularjs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/323623
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d4a8023d17f672f10e83e48fab4e97dc0796af76
Submitter: Jenkins
Branch: master

commit d4a8023d17f672f10e83e48fab4e97dc0796af76
Author: Kevin Fox <email address hidden>
Date: Tue May 31 17:00:20 2016 -0700

    Set some useful default values with the new launch wizard.

    In Mitaka, the new launch instance wizard regresses functionality
    from the old launch wizard with regards to defaults. If there is
    only one neutron network, it is not automatically selected, if
    there is only one keypair, its not selected, and the default
    security group is not automatically selected.

    This patch fixes all of that.

    Change-Id: I23bab6998e38ba1066b926a4fe71713768d9dff4
    Closes-Bug: #1587681

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/324364

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to horizon (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/325211

Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
milestone: newton-2 → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to horizon (master)

Reviewed: https://review.openstack.org/325211
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b3b88310e10d4315b6455f25a63d21e17100f57f
Submitter: Jenkins
Branch: master

commit b3b88310e10d4315b6455f25a63d21e17100f57f
Author: Rob Cresswell <email address hidden>
Date: Fri Jun 3 10:32:07 2016 +0100

    Add missing unit tests to NG launch instance

    https://review.openstack.org/#/c/323623/ added a few new defaults to the
    Launch Instance but didn't add any tests, so the backport is blocked on
    coverage. Rather than lower coverage, we should just add the tests and
    squash the two commits in the backport.

    Fastest way to verify is to generate coverage in master, look at the
    lines added by https://review.openstack.org/#/c/323623/ (red) then apply
    this patch and run again. You'll see they are all white.

    Change-Id: I07d2f5ebcb1771a548c0066699194ea619e7461c
    Related-Bug: #1587681

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to horizon (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/327042

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/mitaka)

Change abandoned by Rob Cresswell (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/324364
Reason: Patch is now here: https://review.openstack.org/#/c/327042/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to horizon (stable/mitaka)

Reviewed: https://review.openstack.org/327042
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=57e44420e8f15ef4f5e304fcfac19373fa0751b2
Submitter: Jenkins
Branch: stable/mitaka

commit 57e44420e8f15ef4f5e304fcfac19373fa0751b2
Author: Rob Cresswell <email address hidden>
Date: Wed Jun 8 12:46:47 2016 +0100

    Improve new Launch Instance defaults + tests

    commit 42a22cba55c6f9e43a9ed37f0487d9d765616641
    Author: Rob Cresswell <email address hidden>
    Date: Fri Jun 3 10:32:07 2016 +0100

        Add missing unit tests to NG launch instance

        https://review.openstack.org/#/c/323623/ added a few new defaults to the
        Launch Instance but didn't add any tests, so the backport is blocked on
        coverage. Rather than lower coverage, we should just add the tests and
        squash the two commits in the backport.

        Fastest way to verify is to generate coverage in master, look at the
        lines added by https://review.openstack.org/#/c/323623/ (red) then apply
        this patch and run again. You'll see they are all white.

        Change-Id: I07d2f5ebcb1771a548c0066699194ea619e7461c
        Related-Bug: #1587681
        (cherry picked from commit b3b88310e10d4315b6455f25a63d21e17100f57f)

    commit 883552578acb30210dcd7533e8b6224551e5785f
    Author: Kevin Fox <email address hidden>
    Date: Tue May 31 17:00:20 2016 -0700

        Set some useful default values with the new launch wizard.

        In Mitaka, the new launch instance wizard regresses functionality
        from the old launch wizard with regards to defaults. If there is
        only one neutron network, it is not automatically selected, if
        there is only one keypair, its not selected, and the default
        security group is not automatically selected.

        This patch fixes all of that.

        Change-Id: I23bab6998e38ba1066b926a4fe71713768d9dff4
        Closes-Bug: #1587681
        (cherry picked from commit d4a8023d17f672f10e83e48fab4e97dc0796af76)

    Change-Id: I0f5c056db62915b4b50d4accba0b4645c88bffde

tags: added: in-stable-mitaka
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 9.1.0

This issue was fixed in the openstack/horizon 9.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/horizon 9.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.