A yesno filter should consider string

Bug #1587263 reported by Hiroyuki Eguchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Undecided
Unassigned

Bug Description

A yesno filter should consider string

For instance, a bootable item in cinder volume
can be string "true" or string "false".

So, a yesno filter returns "Yes" if value of bootable is string "false".

There is a possibility of same case in other item.

By all rights, we should change the type from string to boolean.
However, It would be better for us to consider a string data type in yesno filter.

Changed in horizon:
assignee: nobody → Hiroyuki Eguchi (h-eguchi)
Changed in horizon:
status: New → In Progress
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :
Changed in horizon:
importance: Undecided → Wishlist
milestone: none → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Hiroyuki Eguchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/322707

Revision history for this message
Akihiro Motoki (amotoki) wrote :

The reported issue cannot be reproduced in the master branch (queens). The volume table filter now uses the server-side filtering which means the cinder API does filtering, so I guess it works. This is one of the right approaches.

As discussed in the proposed review, we agreed that it is not a good idea to add a workaround in the yesno filter itself. Instead, we should fix a problem in the API layer of Cinder (which is best), the API wrapper in horizon or the JS REST API layer.

From the above, yesno filter should not be touched, so Won't Fix.

Changed in horizon:
milestone: next → none
assignee: Hiroyuki Eguchi (h-eguchi) → nobody
importance: Wishlist → Undecided
status: In Progress → Won't Fix
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Invalid looks an approach status.

Changed in horizon:
status: Won't Fix → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.