Angular Edit Image buttons styled wrong

Bug #1584207 reported by Matt Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Matt Borland

Bug Description

If you compare the buttons in the Angular Edit Image versus the Create Image, you'll notice that the Edit Image buttons look odd. This is because they use the wrong element for styling (button instead of label). This may actually be more of a global styling problem, but for now we should just align the two to look nice.

Tags: angularjs
Matt Borland (palecrow)
tags: added: angularjs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/319955

Changed in horizon:
assignee: nobody → Matt Borland (palecrow)
status: New → In Progress
Revision history for this message
Matt Borland (palecrow) wrote :

To be more clear, in the Material theme you can see the difference between the buttons; with the incorrect styling they appear grey whereas in the Create Image flow you see they are more white.

Changed in horizon:
importance: Undecided → Low
milestone: none → newton-1
Revision history for this message
Matt Borland (palecrow) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/319955
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=14f40d67991cc7ad4e55b71f5f9c4df18c67b201
Submitter: Jenkins
Branch: master

commit 14f40d67991cc7ad4e55b71f5f9c4df18c67b201
Author: Matt Borland <email address hidden>
Date: Mon May 23 08:01:40 2016 -0600

    Use 'label' rather than 'button' for buttons in Edit Image

    Per the bug, it seems the styling for the Edit buttons requires that the
    elements are of type 'label' and not type 'button.' Otherwise, the buttons
    look odd, particularly if you look at them in the 'Material' theme. This
    patch changes those buttons to labels.

    Change-Id: I4f329513f0ec093fae84394c3094dc526e1a9b9e
    Closes-Bug: 1584207

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.