cinder_policy.json action does not match the Cinder policy.json file

Bug #1582725 reported by Doug Schveninger
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Medium
Rob Cresswell
Ubuntu Cloud Archive
Undecided
Unassigned
Mitaka
Medium
Seyeong Kim
horizon (Ubuntu)
Medium
Unassigned
Xenial
Medium
Seyeong Kim

Bug Description

[Impact]
cinder policies are not in horizon's policy.json
so unset tab "consistency groups" is enabled by default.

Affected to Xenial, UCA_Mitaka

[Test Case]
1. deploy simple openstack deployments via juju
2. horizon -> volume -> check if there is consistency groups tab

[Regression]
after this patch, horizon needs to be restarted. so it is down shortly. this patch is actually config file changed ( and little source code ). so limited affection to behavior it self.

[Other]

related commit

https://git.openstack.org/cgit/openstack/horizon/commit/?id=388708b251b0487bb22fb3ebb8fcb36ee4ffdc4f

[Original Description]

The horizon/openstack_dashboard/conf/cinder_policy.json actions do not match the policy action that are used by the Cinder component.
Cinder uses "volume_extension:volume_actions:upload_public"
and Horizon policy.json and code uses "volume:upload_to_image"

This is the only miss match of policy action between the 2 components. This also does not allow a user of Cinder and Horizon to update the Cinder policy.json and copy it to the Horizon directly and have the button function according to Cinder policy.json rules.

This can be missed as the Cinder policy.json file is update and the Horizon file is updated.

I think that the action that the Horizon code is using should match it component that it is supporting.

Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
milestone: none → newton-1
importance: Undecided → Medium
Changed in horizon:
status: New → In Progress
Revision history for this message
Rob Cresswell (robcresswell) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/249379
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=388708b251b0487bb22fb3ebb8fcb36ee4ffdc4f
Submitter: Jenkins
Branch: master

commit 388708b251b0487bb22fb3ebb8fcb36ee4ffdc4f
Author: daniel-a-nguyen <email address hidden>
Date: Tue Nov 24 10:59:24 2015 -0800

    Updates horizon's copy of the cinder policy file

    Change-Id: I7b83f0d97c330c9fe996fb752f6de57561295bde
    Closes-Bug: 1582725
    Co-Authored-By: Rob Cresswell <email address hidden>
    Implements: blueprint update-cinder-policy-file

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message
Seyeong Kim (seyeongkim) wrote :
description: updated
tags: added: sts
tags: added: sts-sru-needed
Revision history for this message
Seyeong Kim (seyeongkim) wrote :
Seyeong Kim (seyeongkim)
description: updated
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

for kilo and prior to it.

need more 6 commits.. I'm not sure it is backportable.

Somebody can confirm this is backportable or not?

Revision history for this message
Rob Cresswell (robcresswell) wrote :

Why are you commenting on a 2 year old bug? It's is certainly. It's backportable to Kilo, which was end of life more than a year ago now.

Revision history for this message
Rob Cresswell (robcresswell) wrote :

Not backportable**

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Rob, I think you can ignore updates to this bug. These are just for Ubuntu support at this point.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Seyeong, I'm hesitant to backport a large batch of policy changes to a stable release that can change access behavior. Can we limit the policy changes to the specific issue with the consistency groups tab?

Revision history for this message
Rob Cresswell (robcresswell) wrote :

Ah, right you are. I'll turn off my alerts; sorry about that.

Revision history for this message
Seyeong Kim (seyeongkim) wrote :
Revision history for this message
Seyeong Kim (seyeongkim) wrote :
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

@corey

thanks for review.

I re-attached simple version of patches.

James Page (james-page)
Changed in horizon (Ubuntu):
status: New → Fix Released
Changed in cloud-archive:
status: New → Fix Released
Changed in horizon (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → Medium
Seyeong Kim (seyeongkim)
Changed in horizon (Ubuntu Xenial):
assignee: nobody → Seyeong Kim (xtrusia)
Mathew Hodson (mhodson)
Changed in horizon (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Corey Bryant (corey.bryant) wrote :

This has been uploaded to the xenial review queue and is awaiting SRU review: https://launchpad.net/ubuntu/xenial/+queue?queue_state=1&queue_text=

Revision history for this message
Seyeong Kim (seyeongkim) wrote :

@corey.bryant

horizon uploaded for -proposed queue has rejected I just checked it.

something wrong in this?

Thanks.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Seyeong, There were no problems found with this fix. There is another fix currently in xenial-proposed that failed testing and we need to reject and that will have to be removed from the upload for this bug. I'm working on it and have another SRU to pair up with it.

Revision history for this message
Seyeong Kim (seyeongkim) wrote :

Ah I see, Thanks a lot

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Doug, or anyone else affected,

Accepted horizon into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/horizon/2:9.1.2-0ubuntu5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in horizon (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

Hello

I tested this
1. deploy xenial openstack env.
2. check if there is consistency groups tab
3. upgrade openstack-dashboard pkg in -proposed
4. check if there is consistency groups tab ( it is gone )

thanks.

dpkg -l | grep openstack-dashboard

ii openstack-dashboard 2:9.1.2-0ubuntu5 all Django web interface for OpenStack
ii openstack-dashboard-ubuntu-theme 2:9.1.2-0ubuntu5 all Ubuntu theme for the OpenStack dashboard

tags: added: verification-done
removed: verification-needed
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hello Doug, or anyone else affected,

Accepted horizon into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-mitaka-needed
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

Hello

Tested -proposed pkg

1. deploy trusty-mitaka openstack env.
2. check if there is consistency groups tab ( there is )
3. upgrade opesntack-dashboard pkg in -proposed
4. check if there is consistency groups tab ( it is gone )

Thanks!

dpkg -l | grep openstack-dashboard

ii openstack-dashboard 2:9.1.2-0ubuntu5~cloud0 all Django web interface for OpenStack
ii openstack-dashboard-ubuntu-theme 2:9.1.2-0ubuntu5~cloud0 all Ubuntu theme for the OpenStack dashboard

tags: added: verification-mitaka-done
removed: verification-mitaka-needed
Revision history for this message
Corey Bryant (corey.bryant) wrote : Update Released

The verification of the Stable Release Update for horizon has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package horizon - 2:9.1.2-0ubuntu5~cloud0
---------------

 horizon (2:9.1.2-0ubuntu5~cloud0) trusty-mitaka; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (2:9.1.2-0ubuntu5) xenial; urgency=medium
 .
   [ Seyeong Kim ]
   * Hide unused consistency groups tab (LP: #1582725)
     - d/p/hide-unused-consistency-groups.patch: Pick some policies from
       upstream commit 388708b251b0487bb22fb3ebb8fcb36ee4ffdc4f to hide
       unused consistency groups tab.
 .
   [ Corey Bryant ]
   * d/openstack-dashboard.postinst: Ensure permissions are not
     world-readable for /etc/openstack-dashboard/local_settings.py
     (LP: #1755027).
 .
   [ Shane Peters ]
   * d/p/let-nova-to-pick-availability-zone.patch:
     In the Angular Launch Instance, if there is more than one
     availability zone default to the option for the Nova scheduler to pick.
     This is regression from the legacy Launch Instance feature (LP: #1613900).

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Remember: right now we accept only per-release verification-done tags, so a verification-done-xenial tag was needed.

tags: added: verification-done-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package horizon - 2:9.1.2-0ubuntu5

---------------
horizon (2:9.1.2-0ubuntu5) xenial; urgency=medium

  [ Seyeong Kim ]
  * Hide unused consistency groups tab (LP: #1582725)
    - d/p/hide-unused-consistency-groups.patch: Pick some policies from
      upstream commit 388708b251b0487bb22fb3ebb8fcb36ee4ffdc4f to hide
      unused consistency groups tab.

  [ Corey Bryant ]
  * d/openstack-dashboard.postinst: Ensure permissions are not
    world-readable for /etc/openstack-dashboard/local_settings.py
    (LP: #1755027).

  [ Shane Peters ]
  * d/p/let-nova-to-pick-availability-zone.patch:
    In the Angular Launch Instance, if there is more than one
    availability zone default to the option for the Nova scheduler to pick.
    This is regression from the legacy Launch Instance feature (LP: #1613900).

 -- Corey Bryant <email address hidden> Thu, 15 Mar 2018 13:57:14 -0400

Changed in horizon (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers