pre_hook_test fail and sidebar menu fail in integration tests

[Sergei Chipiga]

Right now exception in pre_hook_test in integration tests breaks build. So we need to remove code to restart apache, because it fails pre_test_hook.

Also we need fix bug in sidebar menu click, because right now in tests, after sidebar menu click test doesn't wait until menu collapse will be finished and click next item. But due to collapse isn't finished, next item can't be expanded, and our test waits over 5 mins expanded menu, that is absent, and then test breaks.

[Timur Sufiev (tsufiev-x)]

These 2 issues block the gate, so they should be fixed ASAP.

Proposed patch is at https://review.openstack.org/#/c/309332/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309332
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=79fcc65491052adf50ffe141997c28b658a0461b
Submitter: Jenkins
Branch: master

commit 79fcc65491052adf50ffe141997c28b658a0461b
Author: Sergei Chipiga <email address hidden>
Date: Fri Apr 22 13:00:16 2016 +0300

    Fix pre_test_hook fail and sidebar menu fail

    It fixes two small but important bugs:
    - remove apache restart, because it fails pre_test_hook, which fails
      test build (the latter implication was introduced recently in a
      devstack-gate scripts);
    - fix sidebar menu item click before prev item was collapsed, because
      in this case menu item won't be expanded (supposedly a result of
      recent update of one of XStatic dependencies).

    Change-Id: If463c4c8b16b54f033e2a2ee33ba995ca7844f2b
    Closes-Bug: #1573726

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314017

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314017
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=408114a0bc3df1bce8e65cc54a69a3f5476395a9
Submitter: Jenkins
Branch: stable/mitaka

commit 408114a0bc3df1bce8e65cc54a69a3f5476395a9
Author: Sergei Chipiga <email address hidden>
Date: Fri Apr 22 13:00:16 2016 +0300

    Fix pre_test_hook fail and sidebar menu fail

    It fixes two small but important bugs:
    - remove apache restart, because it fails pre_test_hook, which fails
      test build (the latter implication was introduced recently in a
      devstack-gate scripts);
    - fix sidebar menu item click before prev item was collapsed, because
      in this case menu item won't be expanded (supposedly a result of
      recent update of one of XStatic dependencies).

    Change-Id: If463c4c8b16b54f033e2a2ee33ba995ca7844f2b
    Closes-Bug: #1573726
    (cherry picked from commit 79fcc65491052adf50ffe141997c28b658a0461b)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 9.0.1 release.