Horizon gate is blocked after python-novaclient==4.0.0 release

[Timur Sufiev]

See the typical signature of a failure in unit tests:

2016-04-19 15:59:33.027 | ======================================================================
2016-04-19 15:59:33.027 | ERROR: test_index (openstack_dashboard.contrib.developer.theme_preview.tests.ThemePreviewTests)
2016-04-19 15:59:33.027 | ----------------------------------------------------------------------
2016-04-19 15:59:33.027 | Traceback (most recent call last):
2016-04-19 15:59:33.027 | File "/home/jenkins/workspace/gate-horizon-python27/openstack_dashboard/contrib/developer/theme_preview/tests.py", line 32, in setUp
2016-04-19 15:59:33.028 | super(ThemePreviewTests, self).setUp()
2016-04-19 15:59:33.028 | File "/home/jenkins/workspace/gate-horizon-python27/openstack_dashboard/test/helpers.py", line 169, in setUp
2016-04-19 15:59:33.028 | super(TestCase, self).setUp()
2016-04-19 15:59:33.028 | File "/home/jenkins/workspace/gate-horizon-python27/horizon/test/helpers.py", line 129, in setUp
2016-04-19 15:59:33.028 | self._setup_test_data()
2016-04-19 15:59:33.028 | File "/home/jenkins/workspace/gate-horizon-python27/openstack_dashboard/test/helpers.py", line 173, in _setup_test_data
2016-04-19 15:59:33.028 | test_utils.load_test_data(self)
2016-04-19 15:59:33.029 | File "/home/jenkins/workspace/gate-horizon-python27/openstack_dashboard/test/test_data/utils.py", line 24, in load_test_data
2016-04-19 15:59:33.029 | from openstack_dashboard.test.test_data import nova_data
2016-04-19 15:59:33.029 | File "/home/jenkins/workspace/gate-horizon-python27/openstack_dashboard/test/test_data/nova_data.py", line 33, in <module>
2016-04-19 15:59:33.029 | from novaclient.v2 import volume_snapshots as vol_snaps
2016-04-19 15:59:33.029 | ImportError: cannot import name volume_snapshots

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/308025

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/308137

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308025
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5d6003971f1c41abecd19c40b1384f9efa5210de
Submitter: Jenkins
Branch: master

commit 5d6003971f1c41abecd19c40b1384f9efa5210de
Author: David Lyle <email address hidden>
Date: Tue Apr 19 14:20:17 2016 -0600

    Fix tests broken by novaclient 4.0.0 release

    The release of python-novaclient 4.0.0 removed both volume_types
    and volume_snapshots from the v2 namespace. Both of these data types
    are supplied by cinder, but the Horizon test data was still populating
    them in nova test data and the tests were using the nova values.

    This patch removes the missing namespace references and replaces
    the mocked test data with those mocked for cinder.

    Additionally, the change exposed a rather broken test in the QoS
    for volume_types test suite. This test has been fixed and improved
    to exercise more branches.

    This fix will unblock the gate for Horizon.

    Closes-Bug: #1572246
    Change-Id: I9604cd4046a5ab1486373d0572ddf504d4691196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308137
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e9b83684d2ff19afb1bceefc78b6461d51f437e9
Submitter: Jenkins
Branch: stable/mitaka

commit e9b83684d2ff19afb1bceefc78b6461d51f437e9
Author: David Lyle <email address hidden>
Date: Tue Apr 19 14:20:17 2016 -0600

    Fix tests broken by novaclient 4.0.0 release

    The release of python-novaclient 4.0.0 removed both volume_types
    and volume_snapshots from the v2 namespace. Both of these data types
    are supplied by cinder, but the Horizon test data was still populating
    them in nova test data and the tests were using the nova values.

    This patch removes the missing namespace references and replaces
    the mocked test data with those mocked for cinder.

    Additionally, the change exposed a rather broken test in the QoS
    for volume_types test suite. This test has been fixed and improved
    to exercise more branches.

    This fix will unblock the gate for Horizon.

    Closes-Bug: #1572246
    (cherry picked from commit 5d6003971f1c41abecd19c40b1384f9efa5210de)

    A merge conflict was resolved when cherry picking this change from the
    master branch due to commit fd92d8ec59c2f4d91f4a1c5463d95d1237f07b21.

    Conflicts:
     openstack_dashboard/dashboards/project/volumes/volumes/tests.py

    Change-Id: I9604cd4046a5ab1486373d0572ddf504d4691196

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/308732

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308732
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb8653f8ed8b2fe0fa480ed7aee9fd4942dc00c3
Submitter: Jenkins
Branch: stable/liberty

commit fb8653f8ed8b2fe0fa480ed7aee9fd4942dc00c3
Author: David Lyle <email address hidden>
Date: Tue Apr 19 14:20:17 2016 -0600

    Fix tests broken by novaclient 4.0.0 release

    The release of python-novaclient 4.0.0 removed both volume_types
    and volume_snapshots from the v2 namespace. Both of these data types
    are supplied by cinder, but the Horizon test data was still populating
    them in nova test data and the tests were using the nova values.

    This patch removes the missing namespace references and replaces
    the mocked test data with those mocked for cinder.

    Additionally, the change exposed a rather broken test in the QoS
    for volume_types test suite. This test has been fixed and improved
    to exercise more branches.

    This fix will unblock the gate for Horizon.

    Closes-Bug: #1572246
    (cherry picked from commit e9b83684d2ff19afb1bceefc78b6461d51f437e9)

    A merge conflict was resolved when cherry picking this change from the
    mitaka branch due to commit:
      36c763168a9bbbac7cf62542a1b6210de9e829b3
      dfeb362b95f2b481ff3231b4821d4a5e94fa2e89
      16e82290752597bad443c81236fc25fe7344c3fe

    Conflicts:
     openstack_dashboard/dashboards/admin/volumes/volume_types/tests.py
     openstack_dashboard/dashboards/project/volumes/cgroups/tests.py
     openstack_dashboard/dashboards/project/volumes/volumes/tests.py

    Change-Id: I9604cd4046a5ab1486373d0572ddf504d4691196

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 9.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 8.0.2 release.