Network wizard allocation pools breaks Disable Gateway checkbox and field behavior

[Timur Sufiev]

I found that 'Disable Gateway' checkbox works weirdly with new 'Allocate Network address from a pool' feature: when I first change it from manual mode to pool mode, Gateway Address field disappears, but once I check and uncheck 'Disable Gateway' checkbox field it reappears again.

Moreover, if I check 'Disable Gateway' while in pool mode, then switch to manual mode, Gateway Address field reappears even with 'Disable Gateway' checkbox checked.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263249
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb804ac4ada82c862905a1f24069ee78c6e8fe4e
Submitter: Jenkins
Branch: master

commit fb804ac4ada82c862905a1f24069ee78c6e8fe4e
Author: Bo Wang <email address hidden>
Date: Mon Jan 4 21:02:44 2016 +0800

    Fix workflow bug in "Create Network" dialog

    In "Subnet Info" tab, the button "Next" will hide and
    button "Create" will show if checked Disable Gateway.
    Because value of hide_tab is undefined but transformed to
    hide_tab = ['undefined'] in js code.

    Remove unused ',' which will introduce empty element in list:
    String(['a', 'b',]).split(,) --> ['a', 'b', '']

    Switching field "address_source" should not trigger
    field "gateway_ip" show/disappear.

    Closes-Bug: #1487005
    Closes-Bug: #1530729
    Closes-Bug: #1569942
    Change-Id: If9e417e151e11c8ee46ded50ee3ee8108ed777a4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/316768

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316768
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a5974142664360128154eafcbfb9cd3156c5ddaa
Submitter: Jenkins
Branch: stable/mitaka

commit a5974142664360128154eafcbfb9cd3156c5ddaa
Author: Bo Wang <email address hidden>
Date: Mon Jan 4 21:02:44 2016 +0800

    Fix workflow bug in "Create Network" dialog

    In "Subnet Info" tab, the button "Next" will hide and
    button "Create" will show if checked Disable Gateway.
    Because value of hide_tab is undefined but transformed to
    hide_tab = ['undefined'] in js code.

    Remove unused ',' which will introduce empty element in list:
    String(['a', 'b',]).split(,) --> ['a', 'b', '']

    Switching field "address_source" should not trigger
    field "gateway_ip" show/disappear.

    Closes-Bug: #1487005
    Closes-Bug: #1530729
    Closes-Bug: #1569942
    Change-Id: If9e417e151e11c8ee46ded50ee3ee8108ed777a4
    (cherry picked from commit fb804ac4ada82c862905a1f24069ee78c6e8fe4e)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 9.0.1 release.