Untranslated help text found in Launch Instance window

Bug #1561558 reported by Yuko Katabami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Kenji Ishii

Bug Description

Project > Instances > Launch Instance > Source
Project > Instances > Launch Instance > Security Groups

Found the following untranslated help text in Launch Instance window.

[Source tab]
Image: This option uses an image to boot the instance.
Instance Snapshot: This option uses an instance snapshot to boot the instance.

Image (with Create New Volume checked): This options uses an image to boot the instance, and creates a new volume to persist instance data. You can specify volume size and whether to delete the volume on deletion of the instance.

Volume: This option uses a volume that already exists. It does not create a new volume. You can choose to delete the volume on deletion of the instance. Note: when selecting Volume, you can only launch one instance.

Volume Snapshot: This option uses a volume snapshot to boot the instance, and creates a new volume to persist instance data. You can choose to delete the volume on deletion of the instance.

[Security Groups tab]

Security groups define a set of IP filter rules that determine how network traffic flows to and from an instance. Users can add additional rules to an existing security group to further define the access options for an instance. To create additional rules, go to the Compute | Access & Security view, then find the security group and click Manage Rules.

Translations are already completed in Zanata and other latest translations have been imported to the test envrionment.

Revision history for this message
Yuko Katabami (ykatabam) wrote :
Revision history for this message
Yuko Katabami (ykatabam) wrote :
Changed in horizon:
status: New → Incomplete
status: Incomplete → Confirmed
tags: added: i18n
Changed in horizon:
importance: Undecided → High
milestone: none → newton-1
Revision history for this message
Eddie Ramirez (ediardo) wrote :

In addition to this bug, I've found what I guess more problems with translation, this screenshot was tested when using SPanish Language.

Eddie Ramirez (ediardo)
Changed in horizon:
assignee: nobody → Eddie Ramirez (ediardo)
Revision history for this message
Eddie Ramirez (ediardo) wrote :

There's also a small typo in the current English version; it reads "This options" instead of "This option" or "These options". Check the screenshot attached by Yuko.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

It seems that this bug happens when a source string contains some tags like <b>.

tags: added: mitaka-backport-potential
Eddie Ramirez (ediardo)
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/298476

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Eddie Ramirez (<email address hidden>) on branch: master
Review: https://review.openstack.org/298476
Reason: Another patch fixed root cause of this bug.

Changed in horizon:
milestone: newton-1 → newton-2
Eddie Ramirez (ediardo)
Changed in horizon:
assignee: Eddie Ramirez (ediardo) → nobody
Revision history for this message
Eddie Ramirez (ediardo) wrote :

There was another patch that fixed this but need to find it... but I think this bug can be "invalidad" now

Changed in horizon:
milestone: newton-2 → newton-3
Revision history for this message
Kenji Ishii (ken-ishii) wrote :

I tested latest version but I can still see this issue.
It just depends on my env?

Kenji Ishii (ken-ishii)
Changed in horizon:
assignee: nobody → Kenji Ishii (ken-ishii)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/349442

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/349442
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e3ef7ae51caa91dc7365e6ded634387f59141c43
Submitter: Jenkins
Branch: master

commit e3ef7ae51caa91dc7365e6ded634387f59141c43
Author: Kenji Ishii <email address hidden>
Date: Mon Aug 1 19:04:08 2016 +0900

    Fix untranslated help text in Launch Instance window

    - Source tab
      Flow context is not allowed to write to inner phrasing content,
      At the moment untranslation is occurred by a incorrect value of .html().
      <p translate><li>yyy</li></p> -> elem.html() // value is ''
      <p translate>xxx<li>yyy</li></p> -> elem.html() // value is 'xxx'
      This phenomenon is caused by below.

      html in html file
        <p translate><li>yyy</li>xxx</p>

      html rendered in browser
        <p tramslate></p><li>yyy</li><p></p>

    - Security Groups tab
      '&' needs html escape

    Change-Id: Ic414d232063cc12333ac2d70fd8f351a35a00b6d
    Closes-Bug: #1561558

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b3

This issue was fixed in the openstack/horizon 10.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.