Modal windows don't close with ESC key in at least one scenario

Bug #1561193 reported by Eddie Ramirez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Unassigned

Bug Description

When the user opens a modal window and clicks on an element that is NOT a form input and tries to close the modal window pressing the ESC key, the modal window will not close.

How to reproduce:
1. Open a modal window, e.g. Try to create a new volume, instance or image.
2. Click on an element that is NOT a form input, e.g "Description Text", or a white space or any other element that makes inputs to lose focus.
3. Press the ESC key and the modal window won't close.

The modal window DO close if a form input has focus, but if any of those elements loses focus then using ESC key to close the window will not work.

UPDATE #1: Pressing ESC key when creating instances does seem to work. But still the other behavior exists When creating volumnes or images.

Eddie Ramirez (ediardo)
description: updated
Changed in horizon:
status: New → Confirmed
importance: Undecided → Wishlist
milestone: none → ongoing
Changed in horizon:
milestone: ongoing → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/341114

Changed in horizon:
assignee: nobody → Yosef Hoffman (yh128t)
status: Confirmed → In Progress
Revision history for this message
Eddie Ramirez (ediardo) wrote :

This bug can be closed now since angular-ui-bootstrap 2.2.0 fixes this.

Changed in horizon:
assignee: Yosef Hoffman (yohoffman) → Rob Cresswell (robcresswell)
tags: added: ocata-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/341114
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=180a0d1da7b6b1da1bfbe2d0fae4f039b778ed68
Submitter: Jenkins
Branch: master

commit 180a0d1da7b6b1da1bfbe2d0fae4f039b778ed68
Author: Yosef Hoffman <email address hidden>
Date: Wed Jun 29 05:51:49 2016 -0400

    Close modals with ESC key

    Currently, when the user opens a modal window and clicks on an element
    that is NOT a form input and tries to close the modal window by pressing
    the ESC key, the modal window will not close. This patch allows the user
    to close modals by pressing the ESC key no matter what element on the
    page has the focus.

    The fix is taken from https://getbootstrap.com/javascript/#live-demo

    Co-Authored-By: Rob Cresswell <email address hidden>

    Change-Id: I4d19fb400dee8132d9d490507c06989c07ce42ac
    Closes-Bug: #1561193

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/443089

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/ocata)

Reviewed: https://review.openstack.org/443089
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6b3fcb2f0f13927b8877a7e90a38b4adf3956eb7
Submitter: Jenkins
Branch: stable/ocata

commit 6b3fcb2f0f13927b8877a7e90a38b4adf3956eb7
Author: Yosef Hoffman <email address hidden>
Date: Wed Jun 29 05:51:49 2016 -0400

    Close modals with ESC key

    Currently, when the user opens a modal window and clicks on an element
    that is NOT a form input and tries to close the modal window by pressing
    the ESC key, the modal window will not close. This patch allows the user
    to close modals by pressing the ESC key no matter what element on the
    page has the focus.

    The fix is taken from https://getbootstrap.com/javascript/#live-demo

    Co-Authored-By: Rob Cresswell <email address hidden>

    Change-Id: I4d19fb400dee8132d9d490507c06989c07ce42ac
    Closes-Bug: #1561193
    (cherry picked from commit 180a0d1da7b6b1da1bfbe2d0fae4f039b778ed68)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.1

This issue was fixed in the openstack/horizon 11.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.