Angular actions menu does not close after clicking action

[Justin Pomeroy]

I'm not sure when this started but I noticed today that the angular actions menu does not close on its own after clicking on an action. You need to click somewhere else on the page for the menu to close itself.

[Daniel Castellanos (luis-daniel-castellanos)]

Steps to reproduce?

[Justin Pomeroy (jpomero)]

You need an angular table with multiple actions so there is a dropdown menu. Then just perform any of the actions in the dropdown. The angular Images table is probably the most convenient place to reproduce. You would have to make sure it's enabled in the plugin file. To do that:

- Edit openstack_dashboard/enabled/_1051_project_ng_images_panel.py
- Set DISABLED = False
- Re-launch your server

This would give you a second Images panel under the Project dashboard which is the angular version of the Images panel.

[Thai Tran (tqtran)]

Hi Justin, I do notice the bug you speak of. All of the actions pop up a modal dialog. Once you click somewhere in the modal (cancel for example) the dropdown closes. Has this always been the default behavior? or is this something new?

[Justin Pomeroy (jpomero)]

I feel like this must have been a recent change but I don't think I have any way of really knowing if that's true. It's possible the angular actions menu has always behaved this way and I just never noticed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/299554

[Matt Borland (palecrow)]

I've recently looked at this and see the behavior, for example at https://review.openstack.org/#/c/316244/ if you select an action that is in the drop-down portion. I'm not sure if this is really a bad thing or not, but I can agree that it exists.

[Matt Borland (palecrow)]

So far, it seems like we aren't quite encapsulating our dropdowns in the way that is suggested, at least in the developer panel. We seem to glom the lead button into a single btn-group, rather than having the caret be in its own btn-group. That might be part of the problem.

[Matt Borland (palecrow)]

e.g. the split button doesn't look quite right: https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/action-list/split-button.html

It has two peer buttons, where the dev panel does not.

[Richard Jones (r1chardj0n3s)]

Is there an instance of the drop-down not going away at all once an action is selected (and any action has been taken)?

[Rob Cresswell (robcresswell-deactivatedaccount)]

Removing assignee due to inactivity

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/299554
Reason: Abandoning for now, hasn't been updated in 4 months. Feel free to restore and update if you get time to work on the patch. Thanks!