the size of close icon are different between delete confirm dialog and other modal dialog .

Bug #1557868 reported by Kenji Ishii
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Kenji Ishii

Bug Description

At the moment, the code is below and the size of this icon are different between delete confirm dialog and other modal dialog .
        <a class='close' data-dismiss='modal'>&times;</a>

We should use the code below.
          <a href="#" class="close" data-dismiss="modal">
            <span class="fa fa-times"></span>
          </a>

Kenji Ishii (ken-ishii)
Changed in horizon:
assignee: nobody → Kenji Ishii (ken-ishii)
Kenji Ishii (ken-ishii)
summary: - the close icon on delete confirm dialog is written by old format.
+ the size of close icon are different between delete confirm dialog and
+ other modal dialog .
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/293252

Changed in horizon:
status: New → In Progress
Changed in horizon:
importance: Undecided → Low
milestone: none → mitaka-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/293252
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f88598f8137b683613d7803a1992d213873c8915
Submitter: Jenkins
Branch: master

commit f88598f8137b683613d7803a1992d213873c8915
Author: Kenji Ishii <email address hidden>
Date: Wed Mar 16 14:27:24 2016 +0900

    Fix the size of the close icon on delete confirm dialog

    Change-Id: I35682659fd88d08eff1e65d645279b6b737438a7
    Closes-bug: #1557868

Changed in horizon:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.