Branding: Material: Angular vs. Django Table Action Danger Button Inconsistency

Bug #1557729 reported by Diana Whitten
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Diana Whitten

Bug Description

https://i.imgur.com/KUHpaae.png

vs.

https://i.imgur.com/zicXft0.png

The morale of the story is ... a button should have either btn-default OR btn-danger ... not both.

Tags: branding
Changed in horizon:
assignee: nobody → Diana Whitten (hurgleburgler)
importance: Undecided → Low
status: New → In Progress
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/293117

tags: added: branding
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/293117
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=88968353537c455d084fd1cca0a7405082d4b164
Submitter: Jenkins
Branch: master

commit 88968353537c455d084fd1cca0a7405082d4b164
Author: Diana Whitten <email address hidden>
Date: Tue Mar 15 11:08:57 2016 -0700

    Angular vs. Django Table Danger Button Inconsistency

    A button should have either btn-default OR btn-danger ... not both.

    This also removes the flashing red change this problem caused when
    adding a 'disabled' class to the button after its already been
    rendered on the page.

    Closes-bug: #1557729
    Closes-bug: #1549957

    Change-Id: I6e035868be4df653438b4d31b462729c3fe06d9f

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.