seperate device owner flag for HA router interface port

Bug #1554519 reported by venkata anil
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
venkata anil

Bug Description

Currently HA router interface port uses DEVICE_OWNER_ROUTER_INTF as device owner(like normal router interface). So to check if a port is a HA router interface port, we have to perform a DB operation.

Neutron server at many places(functions in plugin.py, rpc.py, mech_driver.py [1]) may need check if a port is HA router interface port and perform different set of operations, then it has to access DB for this. Instead if this information is available as port's device owner, we can avoid DB access every time.

[1] ml2_db.is_ha_port(session, port) in below files
https://review.openstack.org/#/c/282874/3/neutron/plugins/ml2/plugin.py
https://review.openstack.org/#/c/282874/3/neutron/plugins/ml2/drivers/l2pop/mech_driver.py

Tags: l3-ha
Changed in neutron:
assignee: nobody → venkata anil (anil-venkata)
Changed in neutron:
importance: Undecided → Low
status: New → Confirmed
tags: added: l3-ha
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291641

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291651

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/291651
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ceebc9f465ea038c2eaac26cfa0a18d3f5cdf7c6
Submitter: Jenkins
Branch: master

commit ceebc9f465ea038c2eaac26cfa0a18d3f5cdf7c6
Author: venkata anil <email address hidden>
Date: Tue Mar 22 10:03:58 2016 +0000

    use separate device owner for HA router interface

    Currently HA router interface port uses DEVICE_OWNER_ROUTER_INTF as
    device owner(like normal router interface). So to check if a port is
    a HA router interface port, we have to perform a DB operation.

    Neutron server at many places may need check if a port is HA router
    interface port and perform different set of operations, then it has
    to access DB for this. Instead of that, if this information is
    available as port's device owner, we can avoid DB access every time.

    Closes-bug: #1554519
    Change-Id: I322c392529c04aca2448fd957a35f4908b323449

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.openstack.org/291641
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=0440878cc61737cf68a2f5780fc8af57845078fd
Submitter: Jenkins
Branch: master

commit 0440878cc61737cf68a2f5780fc8af57845078fd
Author: venkata anil <email address hidden>
Date: Fri Mar 11 10:08:01 2016 +0000

    New device owner flag for HA router interface

    Currently HA router interface port uses DEVICE_OWNER_ROUTER_INTF as
    device owner(like normal router interface). So to check if a port is
    a HA router interface port, we have to perform a DB operation.

    Neutron server at many places may need check if a port is HA router
    interface port and perform different set of operations, then it has
    to access DB for this. Instead of that, if this information is
    available as port's device owner, we can avoid DB access every time.

    Partial-Bug: #1554519
    Change-Id: I89b247bdac3aee1e47ee8a1c9f1cb2c385019a51

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.