Annotaion in rest create_user is confusing

Bug #1553148 reported by Wang Bo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Wang Bo

Bug Description

email is an optional argument, both '' and None could successfully create a new user with no email info. The difference is:
If email=None, the value will be NULL in db.
If email='', there is no value of email column in db.

Clear current annotation "# not sure why email is forced to None, but other code does it"

Tags: keystone
Wang Bo (chestack)
Changed in horizon:
assignee: nobody → Wang Bo (chestack)
Changed in horizon:
status: New → In Progress
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :
Changed in horizon:
importance: Undecided → Low
tags: added: keystone
Changed in horizon:
milestone: none → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/287704
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=16a471f6a7ca01016f18bcec0c11322eb77418c1
Submitter: Jenkins
Branch: master

commit 16a471f6a7ca01016f18bcec0c11322eb77418c1
Author: Bo Wang <email address hidden>
Date: Thu Mar 3 18:35:48 2016 +0800

    Clear confusing annotation in rest create_user

    email should be None if not provided, ref[1]

    [1] https://github.com/openstack/horizon/commit/
    311bbd7d16451e53775d316d0e45e1b47711c358

    Closes-Bug: #1553148
    Change-Id: I0530a78f3b354f06b2d9608f5da7ce31ea80085b

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → newton-2
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.