Branding: Remove unnecessary Horizon variables

Bug #1551492 reported by Diana Whitten on 2016-03-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Low
Diana Whitten

Bug Description

There are many variables inside of openstack_dashboard/static/dashboard/scss/_variables.scss that are unnecessary or actually prohibit themability. These should be removed.

Changed in horizon:
status: New → In Progress
assignee: nobody → Diana Whitten (hurgleburgler)
importance: Undecided → Low

Reviewed: https://review.openstack.org/286367
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=055b83bdaf1cf74685f2cc9a36a5e50903453750
Submitter: Jenkins
Branch: master

commit 055b83bdaf1cf74685f2cc9a36a5e50903453750
Author: Diana Whitten <email address hidden>
Date: Mon Feb 29 18:14:16 2016 -0700

    Remove Horizon scss variables: $code-font-family

    There are many variables inside of
    openstack_dashboard/static/dashboard/scss/_variables.scss that are
    unnecessary or actually prohibit themability. These should be removed.

    partial-bug: #1551492

    Change-Id: I98bc0f37b5e622ce2206bff6a0465c8a78692b3a

Fix proposed to branch: master
Review: https://review.openstack.org/289067

Fix proposed to branch: master
Review: https://review.openstack.org/289093

Reviewed: https://review.openstack.org/288972
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1a13fad398e7499db1bb1ff76bb71663a7da266b
Submitter: Jenkins
Branch: master

commit 1a13fad398e7499db1bb1ff76bb71663a7da266b
Author: Diana Whitten <email address hidden>
Date: Sat Mar 5 22:29:43 2016 -0700

    Remove Horizon scss variables: New Launch Instance

    There are many variables inside of
    openstack_dashboard/static/dashboard/scss/_variables.scss that are
    unnecessary or actually prohibit themability. These should be removed.

    After the recent Launch Instance refactoring, a number of variables
    are no longer used.

    partial-bug: #1551492

    Change-Id: I49d906a31e4f8a2f9ba44feedc437fd54027b7ec

Changed in horizon:
assignee: Diana Whitten (hurgleburgler) → Rob Cresswell (robcresswell)

Reviewed: https://review.openstack.org/289067
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=54b9506ed5f51ea1f13a1df1a105d5d7e6452289
Submitter: Jenkins
Branch: master

commit 54b9506ed5f51ea1f13a1df1a105d5d7e6452289
Author: Diana Whitten <email address hidden>
Date: Sun Mar 6 12:21:00 2016 -0700

    Branding: Create Network should inherit from theme

    Create network is different than all other workflows, and it has a
    lot of unnecessary style associated with it. This inhibits
    themability. It should just use standard nav-pills.

    partial-bug: #1551492
    Closes-bug: #1553781

    Change-Id: I6896df03b86ae0c4388ac15246739aeea5365a95

Changed in horizon:
assignee: Rob Cresswell (robcresswell) → Diana Whitten (hurgleburgler)

Reviewed: https://review.openstack.org/289093
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0ba273871204f1fbd9191f16baf5aff721c29643
Submitter: Jenkins
Branch: master

commit 0ba273871204f1fbd9191f16baf5aff721c29643
Author: Diana Whitten <email address hidden>
Date: Sun Mar 6 16:44:51 2016 -0700

    Launch Instance: Metadata should inherit from theme

    The new launch instance's select flavor metadata should inherit from
    theme. Also removing the unneccessary variables from
    dashboard/_variables.scss

    Closes-bug: #1553828
    partial-bug: #1551492

    Change-Id: I5a6f6950068e266ccb6b5c265a794393d1220414

tags: added: branding
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers