delete volume action link is shown even if it shouldn't

[Matthias Runge]

copying a end user bug report here:

Description of problem:
If volume has snaphost, it can't be deleted (need to remove them first). If you navigate to detail of the volume, there exists a link to Delete volume - and it shouldn't be there.

Version-Release number of selected component (if applicable):
liberty

How reproducible:
100%

Steps to Reproduce:
1. log in as demo user
2. Project - Compute - Volumes
3. create Volume with default values, name it "test"
4. verify, that drop down menu of the row with "test" volume contain Delete volume
click to Create snapshot, name it as "test_snap"
navigate back to list of Volumes (not snapshots of them)
verify, that drop down menu of the row with "test" volume does NOT contain Delete volume
click to name of the volume to navigate to detail of volume "test"
on the right top of page there is action button with dropdown menu. There is Delete volume item, that is not accessible from list of volumes

Actual results:
Delete volume item on detail page shouldn't be there, if there exists snapshot of it

Expected results:
Delete volume is visible always (or seems to be)

[Matthias Runge (mrunge)]

if there is a snapshot created from a volume, the delete action is hidden.

[Matthias Runge (mrunge)]

in the volumes details page, there is still a delete action

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/281298

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/281298
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=49a1a6356d8239d5f463c4e09564171dcccaa662
Submitter: Jenkins
Branch: master

commit 49a1a6356d8239d5f463c4e09564171dcccaa662
Author: Masco Kaliyamoorthy <email address hidden>
Date: Wed Feb 17 19:45:38 2016 +0530

    Hide delete volume if it has snapshot

    If the volume has a snapshot, it is not allowed to
    delete it. In tables the delete action is hidden but
    if we go to the volume detail page, the delete action
    is available.

    This patch hides the delete volume on detail page too.

    Change-Id: I4d8690b035dedd7ebcacb3479d346cfb3fb324f1
    Closes-Bug: #1546423

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/283024

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/283024
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=238e2351f8c616931b5be7cfba5ed153bb302bd8
Submitter: Jenkins
Branch: stable/liberty

commit 238e2351f8c616931b5be7cfba5ed153bb302bd8
Author: Masco Kaliyamoorthy <email address hidden>
Date: Wed Feb 17 19:45:38 2016 +0530

    Hide delete volume if it has snapshot

    If the volume has a snapshot, it is not allowed to
    delete it. In tables the delete action is hidden but
    if we go to the volume detail page, the delete action
    is available.

    This patch hides the delete volume on detail page too.

    Change-Id: I4d8690b035dedd7ebcacb3479d346cfb3fb324f1
    Closes-Bug: #1546423
    (cherry picked from commit 49a1a6356d8239d5f463c4e09564171dcccaa662)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 8.0.2 release.