New i9n tests exceptions_captured context manager introduce a bug in failure reports

[Timur Sufiev]

If test fails in a non-fatal for Selenium way and it's still able to fetch page source/ browser log/ screenshot that data is not added to TestCase reports because of lines like https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/helpers.py#L127 where `content` gets thrown away once we return from block https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/helpers.py#L106

To mitigate that we need to use a container instead of single reference.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/279614

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/279614
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d1f08df329da7561142757ac292fd426782f0608
Submitter: Jenkins
Branch: master

commit d1f08df329da7561142757ac292fd426782f0608
Author: Timur Sufiev <email address hidden>
Date: Fri Feb 12 18:43:50 2016 +0300

    Fix exceptions_captured manager in i9n tests

    Recently introduced manager handled only 'bad' failure scenarios when
    Selenium became non responsive and caused again cryptic failures for
    failures that were perfectly reported before exceptions_captured
    introduction. Now both kind of (responsive and non responsive
    Selenium) failures are addressed inside it.

    Change-Id: I564b5e8b35fb2e84c27374bcac8a49cb6262b058
    Closes-Bug: #1545042

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.