Tests fail if a panel is disabled

Bug #1541489 reported by Itxaka Serrano
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
New
Medium
Unassigned

Bug Description

If you disable any panel, all the tests inside that panel will

 - Be run
 - Fail to resolve the reverse url if any

Tests inside Panels should only run if that panel is enabled.

How to test:

 - Create a file _9999_disable_admin_image.py in openstack_dashboard/dashboards/local/enable/ with the following content:
PANEL = 'images'
PANEL_DASHBOARD = 'admin'
PANEL_GROUP = 'admin'
REMOVE_PANEL = True

 - Run openstack_dashboard and confirm that the images panel under admin is gone
 - Run the tests and observe the images tests failing with NoReverseMatch

Itxaka Serrano (itxaka)
Changed in horizon:
assignee: nobody → Itxaka Serrano (itxakaserrano)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/275817

Changed in horizon:
status: New → In Progress
summary: - disable tests if panel are disabled
+ Tests fail if a panel is disabled
Changed in horizon:
importance: Undecided → Medium
milestone: none → ongoing
Changed in horizon:
milestone: ongoing → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Itxaka Serrano Garcia (<email address hidden>) on branch: master
Review: https://review.openstack.org/275817
Reason: Seems that is not clear if this is needed or not, feel free to restore and continue working on it if needed.

Akihiro Motoki (amotoki)
Changed in horizon:
assignee: Itxaka Serrano (itxaka) → nobody
status: In Progress → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.