Angular Launch Instance should use adhere to Horizon theming standards

Bug #1538491 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Unassigned

Bug Description

The Angular Launch Instance workflow is totally separate from the rest of the Horizon design and theming. It should use the bootstrap markup and theming where possible.

Changed in horizon:
status: New → In Progress
Revision history for this message
David Lyle (david-lyle) wrote :

moved to high as it blocks turning on the new Launch Instance as the default.

Changed in horizon:
importance: Wishlist → High
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/287531

Changed in horizon:
assignee: Rob Cresswell (robcresswell) → Diana Whitten (hurgleburgler)
Changed in horizon:
assignee: Diana Whitten (hurgleburgler) → Rob Cresswell (robcresswell)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/285084
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=be9023d86e058d81d6c2504e87c3a385f34472e6
Submitter: Jenkins
Branch: master

commit be9023d86e058d81d6c2504e87c3a385f34472e6
Author: Rob Cresswell <email address hidden>
Date: Wed Feb 24 13:45:17 2016 -0800

    Fix theming in angular launch instance

    This patch makes the new angular Launch Instance workflow mostly
    themeable. Most of the existing CSS has been deleted, and this now
    follows bootstraps markup. This is not intended to solve all edge cases
    given the size of the work, but is a big step in the right direction.

    Changes:
    - Use stacked nav tabs for navigation. Move base nav tabs toward
      bootstrap default. Style primary side nav as before.
    - Use bootstraps form markup for modal
    - Use bootstraps form markup for form fields and their errors
    - Make pie charts and tables inherit any missing theme variables. A more
      thorough pass will be done on this next release cycle.

    Closes-Bug: 1538491
    Change-Id: Ic20b7f4341a2853ca334824c6a811125b04e88cc

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/287531
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6a72d2c44be8f09ae9df055157701372e6ac81e0
Submitter: Jenkins
Branch: master

commit 6a72d2c44be8f09ae9df055157701372e6ac81e0
Author: Diana Whitten <email address hidden>
Date: Wed Mar 2 17:49:43 2016 -0700

    Material Design: New LI Tweaks

    Some things on the new LI needed tweaking for material design:

     * Help Icon Strangeness -- Snazz added
     * Material Icon Alignment -- Removed Custom Size
     * Required Icon Size Strangeness - Specificity Required

    Change-Id: I09620f25192352ab47dd329e8a594a9fd091a6a3
    partial-bug: 1538491

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.